Depending on the protocol, we have a different order of operations when sending a message.
Depends on D14630
Details
Details
Tested sending text messages on web - made sure that the side effects are executed in thin and thick threads.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
LGTM but I wonder if those side effects and deciding when to call them should be included in the protocol and handled in sendTextMessage(...) method. Then every protocol (dm/keyserver/other) has just "sendTextMessage" method and protocol decides when side effects should be performed. Also in useCreationSideEffectsFunc there are also conditionals threadTypeIsThick so the side effects can be different for different protocols.
Or in other words: Imagine a user of the protocol who wants to send a text message. I think it's way easier to use if a protocol is just "sendTextMessage and I'll take care of the side effects and when to call them" instead of "call this sendTextMessage but before that use this boolean to check whether you should apply those side effects first or last".
Comment Actions
I think it is a good idea. Addressing it here might be inconvenient, and is something a little more complicated, so I created a task to track https://linear.app/comm/issue/ENG-10784/merge-sendtextmessage-with.