Create a flag in the spec and use it in all the places.
Depends on D14614
Details
Details
On both platforms, send an image in thin and thick thread and check if the image is correctly displayed on the receiver's side.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/shared/threads/thread-spec.js | ||
|---|---|---|
| 216 ↗ | (On Diff #47889) | Actually I think this is more accurate, we do upload all media do Blob Service and sometimes their metadata to keyserver |
| lib/shared/threads/thread-spec.js | ||
|---|---|---|
| 216 ↗ | (On Diff #47889) | This makes sense, but we're also using this flag in input-state-container.react.js where we decide where to upload inside uploadFile function. It looks like we're deciding about the whole upload and not just metadata. Is it correct? In that case, should we keep this flag, rename it, or create a separate flag for that case? @bartek |
| lib/shared/threads/thread-spec.js | ||
|---|---|---|
| 216 ↗ | (On Diff #47889) | If you mean keyserverOrThreadID, it's used to determine where to upload media metadata and other stuff (like storing holders for non-keyserver uploads). Still, the media itself is always uploaded to Blob Service. But the deciding factor is always the metadata location - keyserver or not. |
| lib/shared/threads/thread-spec.js | ||
|---|---|---|
| 216 ↗ | (On Diff #47889) | Ok, in that case, we should rename the flag, thanks! As discussed offline, renaming the field to keyserverOrThreadIDForMetadata also could be beneficial. |