[lib] Simplify unread status types
ClosedPublic
Actions

Authored by tomek on Apr 25 2025, 3:14 PM.

Details

Reviewers

kamil
angelika

Commits

rCOMM1f0f582ba135: [lib] Simplify unread status types

Summary

We can avoid branching the types between thread types which allows migrating to specs.

https://linear.app/comm/issue/ENG-10651/move-managing-unread-status-to-specs

Depends on D14604

Test Plan

Tested in combination with the next diff - checked if it is possible to toggle the status for thin and thick threads on native and web.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Apr 25 2025, 3:14 PM

Herald added a subscriber: ashoat. · View Herald TranscriptApr 25 2025, 3:14 PM

tomek added a child revision: D14606: [lib] Move setting unread status to a spec.Apr 25 2025, 3:16 PM

Harbormaster completed remote builds in B34029: Diff 47864.Apr 25 2025, 3:32 PM

tomek requested review of this revision.Apr 25 2025, 3:32 PM

angelika accepted this revision.Apr 29 2025, 9:18 AM

This revision is now accepted and ready to land.Apr 29 2025, 9:18 AM

Closed by commit rCOMM1f0f582ba135: [lib] Simplify unread status types. · Explain WhyMay 8 2025, 11:29 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM1f0f582ba135: [lib] Simplify unread status types.

Revision Contents
Changeset List

Path

Size

lib/

actions/

activity-actions.js

22 lines

hooks/

toggle-unread-status.js

11 lines

Diff 47975

View Options

lib/actions/activity-actions.js