Differential D14641 Authored by tomek on May 5 2025, 11:46 AM.
Details
Summary Move the logic. This required introducing a type parameter to the specs. This refactoring also revealed an issue with our validation here: due to Flow, we weren't strictly checking if e.g. thick member type is used in a thick thread. This diff keeps this issue, and it won't be easy to fix. Depends on D14640 Test Plan Check if restoring thin and thick threads from DB works.
Diff Detail
Event TimelineHerald added a subscriber: ashoat. · View Herald TranscriptMay 5 2025, 11:46 AM2025-05-05 11:46:24 (UTC+0) Harbormaster completed remote builds in B34075: Diff 47933.May 5 2025, 12:16 PM2025-05-05 12:16:43 (UTC+0) tomek added a child revision: D14642: [lib] Move fetching messages to a spec.May 5 2025, 12:26 PM2025-05-05 12:26:12 (UTC+0) Harbormaster completed remote builds in B34099: Diff 47959.May 7 2025, 5:11 PM2025-05-07 17:11:19 (UTC+0) Harbormaster failed remote builds in B34106: Diff 47971!May 8 2025, 11:32 AM2025-05-08 11:32:39 (UTC+0) Harbormaster completed remote builds in B34108: Diff 47981.May 8 2025, 12:11 PM2025-05-08 12:11:35 (UTC+0) Harbormaster completed remote builds in B34136: Diff 48009.May 9 2025, 12:16 PM2025-05-09 12:16:18 (UTC+0) This revision is now accepted and ready to land.May 21 2025, 11:59 AM2025-05-21 11:59:32 (UTC+0) Harbormaster completed remote builds in B34239: Diff 48175.May 22 2025, 1:45 PM2025-05-22 13:45:37 (UTC+0) Closed by commit rCOMM0fe939413a18: [lib] Move converting DB threads to a spec. · Explain WhyMay 23 2025, 3:50 PM2025-05-23 15:50:51 (UTC+0) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 48191 |