[lib] Choose thread ID behavior in the initial state gate based on the specs
ClosedPublic
Actions

Authored by tomek on May 16 2025, 2:44 PM.

Details

Reviewers

kamil
angelika

Commits

Summary

Add a flag and choose the behavior based on it. Also, remove the threadIDIsThick function.

Depends on D14711

Test Plan

Checked if closing and reopening the web app works with both thin and thick active threads.

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

tomek requested review of this revision.May 16 2025, 3:08 PM

angelika added inline comments.

web/redux/initial-state-gate.js
102 ↗	(On Diff #48112)	is `urlInfo.thread` needed here? we use it in `getProtocolByThreadID`, if it's null then `getProtocolByThreadID` returns null, so `protocol` is null or we can check if `urlInfo.thread` is null earlier and avoid adding nullable parameter to `getProtocolByThreadID`

This revision is now accepted and ready to land.May 22 2025, 1:51 AM

Simplify

web/redux/initial-state-gate.js
102 ↗	(On Diff #48112)	Makes sense! We can remove `urlInfo.thread` from this line. We can also avoid having a nullable parameter in `getProtocolByThreadID`.