We need to move the hooks so that we avoid an import cycle in the next diff.
https://linear.app/comm/issue/ENG-10635/move-editing-messages-logic-to-specs
Depends on D14593
Differential D14597 Authored by tomek on Apr 24 2025, 4:22 PM.
Details Summary We need to move the hooks so that we avoid an import cycle in the next diff. https://linear.app/comm/issue/ENG-10635/move-editing-messages-logic-to-specs Depends on D14593 Test Plan Tested with the next diff by editing messages.
Diff Detail
Event TimelineHerald added a subscriber: ashoat. · View Herald TranscriptApr 24 2025, 4:22 PM2025-04-24 16:22:22 (UTC+0) tomek added a child revision: D14598: [lib] Move editing messages to the protocol.Apr 24 2025, 4:23 PM2025-04-24 16:23:36 (UTC+0) Harbormaster completed remote builds in B34020: Diff 47854.Apr 24 2025, 4:46 PM2025-04-24 16:46:06 (UTC+0) This revision is now accepted and ready to land.Apr 25 2025, 10:50 AM2025-04-25 10:50:33 (UTC+0) Closed by commit rCOMMd0d08fd04966: [lib] Extract message hooks from message actions to avoid import cycles. · Explain WhyApr 28 2025, 10:43 AM2025-04-28 10:43:38 (UTC+0) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 47877 |