[lib] Introduce sidebar config into a spec
ClosedPublic
Actions

Authored by tomek on Apr 30 2025, 11:39 AM.

Details

Reviewers

kamil
angelika

Commits

rCOMM4d784cd87023: [lib] Introduce sidebar config into a spec

Summary

The config specifies a URL prefix and thread type. It is used in a couple of places.

https://linear.app/comm/issue/ENG-10638/move-managing-sidebars-logic-to-specs

Depends on D14625

Test Plan

Tested creating thick and thin sidebars - verified that the correct URL was present and that the correct thread was created. Also checked creating a personal thread.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Apr 30 2025, 11:39 AM

Herald added a subscriber: ashoat. · View Herald TranscriptApr 30 2025, 11:39 AM

Replace another usage

Harbormaster completed remote builds in B34055: Diff 47909.Apr 30 2025, 12:02 PM

tomek requested review of this revision.Apr 30 2025, 12:02 PM

tomek added a child revision: D14627: [lib] Simplify subscription types.Apr 30 2025, 12:22 PM

Harbormaster failed remote builds in B34054: Diff 47908!May 1 2025, 5:43 AM

angelika accepted this revision.May 6 2025, 1:33 PM

This revision is now accepted and ready to land.May 6 2025, 1:33 PM

Closed by commit rCOMM4d784cd87023: [lib] Introduce sidebar config into a spec. · Explain WhyMay 9 2025, 12:32 PM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM4d784cd87023: [lib] Introduce sidebar config into a spec.

Revision Contents
Changeset List

Path

Size

lib/

shared/

sidebar-utils.js

7 lines

thread-utils.js

31 lines

threads/

protocols/

dm-thread-protocol.js

6 lines

keyserver-thread-protocol.js

7 lines

thread-protocols.js

8 lines

thread-spec.js

5 lines

Diff 48019

View Options

lib/shared/sidebar-utils.js

View Options

lib/shared/thread-utils.js

View Options

lib/shared/threads/protocols/dm-thread-protocol.js

View Options

lib/shared/threads/protocols/keyserver-thread-protocol.js

View Options

lib/shared/threads/protocols/thread-protocols.js

View Options

lib/shared/threads/thread-spec.js

[lib] Introduce sidebar config into a specClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48019

lib/shared/sidebar-utils.js

lib/shared/thread-utils.js

lib/shared/threads/protocols/dm-thread-protocol.js

lib/shared/threads/protocols/keyserver-thread-protocol.js

lib/shared/threads/protocols/thread-protocols.js

lib/shared/threads/thread-spec.js

[lib] Introduce sidebar config into a spec
ClosedPublic
Actions

Revision Contents
Changeset List