[native] fix action sheet padding
ClosedPublic
Actions

Authored by varun on Sep 25 2024, 8:50 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 29, 8:28 AM

	Unknown Object (File)
	Fri, Nov 29, 4:15 AM

	Unknown Object (File)
	Mon, Nov 25, 6:17 PM

	Unknown Object (File)
	Nov 1 2024, 6:13 AM

	Unknown Object (File)
	Nov 1 2024, 12:20 AM

	Unknown Object (File)
	Oct 31 2024, 11:41 PM

	Unknown Object (File)
	Oct 31 2024, 11:41 PM

	Unknown Object (File)
	Oct 31 2024, 11:41 PM

View All 48 Files

Subscribers

tomek

Details

Reviewers

ashoat

Commits

rCOMMdf4780d7fc65: [native] fix action sheet padding

Summary

figured out why the home pill was covering the action sheet options

this was broken in D7506

Test Plan

action sheet looks right on android now

Screenshot_1727322367.png (3×1 px, 161 KB)

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Sep 25 2024, 8:50 PM

Herald added a subscriber: tomek. · View Herald TranscriptSep 25 2024, 8:50 PM

varun edited the test plan for this revision. (Show Details)Sep 25 2024, 8:50 PM

varun attached a referenced file: F2811477: Screenshot_1727322367.png. (Show Details)

varun mentioned this in D13476: [native] add farcaster icon on native.Sep 25 2024, 8:52 PM

Harbormaster completed remote builds in B31863: Diff 44580.Sep 25 2024, 9:07 PM

varun requested review of this revision.Sep 25 2024, 9:07 PM

Nice find!

This revision is now accepted and ready to land.Sep 26 2024, 6:03 AM

Closed by commit rCOMMdf4780d7fc65: [native] fix action sheet padding (authored by varun). · Explain WhySep 26 2024, 7:41 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMdf4780d7fc65: [native] fix action sheet padding.

Revision Contents
Changeset List

Path

Size

native/

avatars/

avatar-hooks.js

2 lines

Diff 44580

View Options

native/avatars/avatar-hooks.js

[native] fix action sheet paddingClosedPublicActions