[identity] Send RETRY for transaction conflicts
ClosedPublic
Actions

Authored by bartek on Oct 2 2024, 1:07 AM.

Details

Reviewers

varun
will

Commits

rCOMMc90015c9f446: [identity] Send RETRY for transaction conflicts

Summary

Part of ENG-9427.

Added a function that checks if DDB error is transaction conflict (we already have one but this one is more opinionated)
Added a case to handle_db_error to send retry tonic message instead of unexpected error

Depends on D13567

Test Plan

Simulated TransactionConflictException DDB error and checked gRPC status code in a UI client

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Oct 2 2024, 1:07 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptOct 2 2024, 1:07 AM

bartek added a child revision: D13569: [identity] Add exponential backoff to refresh_user_prekeys.Oct 2 2024, 1:10 AM

Harbormaster completed remote builds in B32008: Diff 44812.Oct 2 2024, 1:24 AM

bartek published this revision for review.Oct 2 2024, 1:26 AM

will accepted this revision.Oct 2 2024, 6:07 AM

This revision is now accepted and ready to land.Oct 2 2024, 6:07 AM

Closed by commit rCOMMc90015c9f446: [identity] Send RETRY for transaction conflicts (authored by bartek). · Explain WhyOct 3 2024, 1:10 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMc90015c9f446: [identity] Send RETRY for transaction conflicts.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

client_service.rs

6 lines

ddb_utils.rs

24 lines

Diff 44812

View Options

services/identity/src/client_service.rs