Page MenuHomePhabricator

[lib] Bump detect-browser version
ClosedPublic

Authored by tomek on Thu, Oct 3, 3:58 AM.
Tags
None
Referenced Files
F3061082: D13587.id44865.diff
Thu, Oct 24, 10:23 AM
F3060642: D13587.diff
Thu, Oct 24, 8:30 AM
F3059021: D13587.id.diff
Thu, Oct 24, 3:09 AM
Unknown Object (File)
Tue, Oct 22, 11:26 PM
Unknown Object (File)
Tue, Oct 22, 7:54 AM
Unknown Object (File)
Mon, Oct 21, 4:53 AM
Unknown Object (File)
Thu, Oct 17, 8:31 AM
Unknown Object (File)
Fri, Oct 11, 10:22 PM
Subscribers

Details

Summary

We're using an old version that has more limited browsers support. According to the release notes https://github.com/DamonOehlman/detect-browser/releases/tag/v5.0.0 the major version was increased because of a breaking change that removed support for one browser.

https://linear.app/comm/issue/ENG-9477/typeerror-cannot-read-properties-of-null-reading-os-on-landing

Test Plan

Tested on iOS that the correct version is detected in the responder.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage