[web] Add some memos to ComposedMessage
ClosedPublic
Actions

Authored by ashoat on Oct 9 2024, 8:22 PM.

Tags

None

Referenced Files

	F3345865: D13673.id45032.diff
	Fri, Nov 22, 7:15 AM

	F3342264: D13673.diff
	Fri, Nov 22, 12:58 AM

	Unknown Object (File)
	Sun, Nov 10, 5:24 PM

	Unknown Object (File)
	Sun, Nov 10, 4:51 PM

	Unknown Object (File)
	Sun, Nov 10, 11:43 AM

	Unknown Object (File)
	Sun, Nov 10, 5:16 AM

	Unknown Object (File)
	Thu, Nov 7, 2:22 PM

	Unknown Object (File)
	Thu, Oct 31, 2:31 AM

View All 33 Files

Subscribers

None

Details

Reviewers

tomek

Commits

rCOMM050c14188cba: [web] Add some memos to ComposedMessage

Summary

Now that it's a function component, we should take advantage of React hook best practices and memoize as much as we can.

Depends on D13672

Test Plan

Flow and ESLint React hooks rules

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Oct 9 2024, 8:22 PM

ashoat added a child revision: D13674: [web] Move declarations closer to where they're used in ComposedMessage.

Harbormaster completed remote builds in B32157: Diff 45032.Oct 9 2024, 8:44 PM

ashoat requested review of this revision.Oct 9 2024, 8:44 PM

tomek accepted this revision.Oct 10 2024, 8:24 AM

This revision is now accepted and ready to land.Oct 10 2024, 8:24 AM

Closed by commit rCOMM050c14188cba: [web] Add some memos to ComposedMessage (authored by ashoat). · Explain WhyOct 13 2024, 6:43 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM050c14188cba: [web] Add some memos to ComposedMessage.

Revision Contents
Changeset List

Path

Size

web/

chat/

composed-message.react.js

242 lines

Diff 45032

View Options

web/chat/composed-message.react.js

[web] Add some memos to ComposedMessageClosedPublicActions