[web] Add some memos to ComposedMessage
ClosedPublic
Actions

Authored by ashoat on Wed, Oct 9, 8:22 PM.

Tags

None

Referenced Files

	F3099357: D13673.id45032.diff
	Tue, Oct 29, 9:32 PM

	Unknown Object (File)
	Tue, Oct 29, 10:07 AM

	Unknown Object (File)
	Wed, Oct 23, 10:53 PM

	Unknown Object (File)
	Tue, Oct 22, 10:45 PM

	Unknown Object (File)
	Sun, Oct 20, 10:20 PM

	Unknown Object (File)
	Sat, Oct 19, 6:05 AM

	Unknown Object (File)
	Sat, Oct 19, 1:47 AM

	Unknown Object (File)
	Fri, Oct 18, 8:24 PM

View All 23 Files

Subscribers

None

Details

Reviewers

tomek

Commits

rCOMM050c14188cba: [web] Add some memos to ComposedMessage

Summary

Now that it's a function component, we should take advantage of React hook best practices and memoize as much as we can.

Depends on D13672

Test Plan

Flow and ESLint React hooks rules

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Wed, Oct 9, 8:22 PM

ashoat added a child revision: D13674: [web] Move declarations closer to where they're used in ComposedMessage.

Harbormaster completed remote builds in B32157: Diff 45032.Wed, Oct 9, 8:44 PM

ashoat requested review of this revision.Wed, Oct 9, 8:44 PM

tomek accepted this revision.Thu, Oct 10, 8:24 AM

This revision is now accepted and ready to land.Thu, Oct 10, 8:24 AM

Closed by commit rCOMM050c14188cba: [web] Add some memos to ComposedMessage (authored by ashoat). · Explain WhySun, Oct 13, 6:43 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM050c14188cba: [web] Add some memos to ComposedMessage.

Revision Contents
Changeset List

Path

Size

web/

chat/

composed-message.react.js

242 lines

Diff 45032

View Options

web/chat/composed-message.react.js

[web] Add some memos to ComposedMessageClosedPublicActions