Page MenuHomePhabricator

[native] Fix Timestamp position when focusing RobotextMessage with InlineEngagement
ClosedPublic

Authored by ashoat on Oct 9 2024, 8:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 4:55 PM
Unknown Object (File)
Mon, Nov 11, 12:22 PM
Unknown Object (File)
Mon, Nov 11, 5:37 AM
Unknown Object (File)
Sun, Nov 10, 3:11 PM
Unknown Object (File)
Sun, Nov 10, 2:06 PM
Unknown Object (File)
Sun, Nov 10, 10:55 AM
Unknown Object (File)
Sun, Nov 10, 3:18 AM
Unknown Object (File)
Tue, Oct 29, 7:20 AM
Subscribers
None

Details

Summary

We shouldn't include the InlineEngagement in the View that gets measured. By removing this, I fixed a visual glitch where the Timestamp for a robotext message would jump higher on the screen when the robotext was selected.

Depends on D13680

Test Plan
  1. I reacted to a robotext where the timestamp was already showing. Then I pressed it, and made sure there were no visual glitches or logs about incorrect height
  2. Same as above, except where the timestamp wasn't showing

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage