Page MenuHomePhabricator
Differential D13685

[lib][native] Extract chatMessageItemEngagementTargetMessageInfo
ClosedPublic
Actions

Authored by ashoat on Oct 9 2024, 8:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 15, 3:17 AM
Unknown Object (File)
Mon, Mar 3, 6:18 AM
Unknown Object (File)
Feb 17 2025, 10:51 AM
Unknown Object (File)
Feb 17 2025, 10:50 AM
Unknown Object (File)
Feb 17 2025, 10:50 AM
Unknown Object (File)
Feb 16 2025, 1:25 PM
Unknown Object (File)
Feb 16 2025, 10:42 AM
Unknown Object (File)
Feb 3 2025, 4:10 PM
View All 65 Files
Subscribers
None

Details

Reviewers
tomek
Commits
rCOMMa5188d988608: [lib][native] Extract chatMessageItemEngagementTargetMessageInfo
Summary

This will make it easier to change its behavior in a later diff.

Depends on D13684

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Oct 9 2024, 8:30 PM
ashoat added a child revision: D13686: [lib][native][web] Add support for rendering array of messages in RobotextChatMessageInfoItem.
Harbormaster completed remote builds in B32169: Diff 45044.Oct 9 2024, 9:59 PM
ashoat requested review of this revision.Oct 9 2024, 9:59 PM
tomek accepted this revision.Oct 11 2024, 6:12 AM
tomek added inline comments.
lib/shared/chat-message-item-utils.js
43 ↗(On Diff #45044)

I'm not sure what this name means. What makes a message targetable?

This revision is now accepted and ready to land.Oct 11 2024, 6:12 AM
ashoat added inline comments.Oct 13 2024, 5:08 PM
lib/shared/chat-message-item-utils.js
43 ↗(On Diff #45044)

I'll rename to chatMessageItemCanReceiveEngagement for consistency with chatMessageItemHasEngagement

ashoat added inline comments.Oct 13 2024, 5:24 PM
lib/shared/chat-message-item-utils.js
43 ↗(On Diff #45044)

Actually, it returns a MessageInfo so that doesn't make sense. I'll go with chatMessageItemEngagementTargetMessageInfo

ashoat retitled this revision from [lib][native] Extract chatMessageInfoItemTargetableMessageInfo to [lib][native] Extract chatMessageItemEngagementTargetMessageInfo.Oct 13 2024, 5:29 PM
ashoat updated this revision to Diff 45105.Oct 13 2024, 5:32 PM

chatMessageInfoItemTargetableMessageInfo -> chatMessageItemEngagementTargetMessageInfo

Harbormaster completed remote builds in B32209: Diff 45105.Oct 13 2024, 5:51 PM
Closed by commit rCOMMa5188d988608: [lib][native] Extract chatMessageItemEngagementTargetMessageInfo (authored by ashoat). · Explain WhyOct 13 2024, 6:44 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMa5188d988608: [lib][native] Extract chatMessageItemEngagementTargetMessageInfo.

Revision Contents
Changeset List

Diff 45105

View Options

lib/shared/chat-message-item-utils.js

Show All 12 Linesimport {
entryRevisionFetchResponder, entryRevisionFetchResponder,
entryCreationResponder, entryCreationResponder,
entryUpdateResponder, entryUpdateResponder,
entryDeletionResponder, entryDeletionResponder,
entryRestorationResponder, entryRestorationResponder,
calendarQueryUpdateResponder, calendarQueryUpdateResponder,
} from './responders/entry-responders.js'; } from './responders/entry-responders.js';
import type { JSONResponder } from './responders/handlers.js'; import type { JSONResponder } from './responders/handlers.js';
import { getSessionPublicKeysResponder } from './responders/keys-responders.js'; import {
getSessionPublicKeysResponder,
getOlmSessionInitializationDataResponder,
} from './responders/keys-responders.js';
import { inviteLinkVerificationResponder } from './responders/link-responders.js'; import { inviteLinkVerificationResponder } from './responders/link-responders.js';
import { messageReportCreationResponder } from './responders/message-report-responder.js'; import { messageReportCreationResponder } from './responders/message-report-responder.js';
import { import {
textMessageCreationResponder, textMessageCreationResponder,
messageFetchResponder, messageFetchResponder,
multimediaMessageCreationResponder, multimediaMessageCreationResponder,
reactionMessageCreationResponder, reactionMessageCreationResponder,
editMessageCreationResponder, editMessageCreationResponder,
▲ Show 20 Lines • Show All 239 Lines • ▼ Show 20 Linesconst jsonEndpoints: { [id: Endpoint]: JSONResponder } = {
update_user_avatar: { update_user_avatar: {
responder: updateUserAvatarResponder, responder: updateUserAvatarResponder,
requiredPolicies: baseLegalPolicies, requiredPolicies: baseLegalPolicies,
}, },
upload_media_metadata: { upload_media_metadata: {
responder: uploadMediaMetadataResponder, responder: uploadMediaMetadataResponder,
requiredPolicies: baseLegalPolicies, requiredPolicies: baseLegalPolicies,
}, },
get_olm_session_initialization_data: {
responder: getOlmSessionInitializationDataResponder,
requiredPolicies: [],
},
}; };
export { jsonEndpoints }; export { jsonEndpoints };
View Options

lib/shared/sidebar-utils.js

Show All 12 Linesimport {
entryRevisionFetchResponder, entryRevisionFetchResponder,
entryCreationResponder, entryCreationResponder,
entryUpdateResponder, entryUpdateResponder,
entryDeletionResponder, entryDeletionResponder,
entryRestorationResponder, entryRestorationResponder,
calendarQueryUpdateResponder, calendarQueryUpdateResponder,
} from './responders/entry-responders.js'; } from './responders/entry-responders.js';
import type { JSONResponder } from './responders/handlers.js'; import type { JSONResponder } from './responders/handlers.js';
import { getSessionPublicKeysResponder } from './responders/keys-responders.js'; import {
getSessionPublicKeysResponder,
getOlmSessionInitializationDataResponder,
} from './responders/keys-responders.js';
import { inviteLinkVerificationResponder } from './responders/link-responders.js'; import { inviteLinkVerificationResponder } from './responders/link-responders.js';
import { messageReportCreationResponder } from './responders/message-report-responder.js'; import { messageReportCreationResponder } from './responders/message-report-responder.js';
import { import {
textMessageCreationResponder, textMessageCreationResponder,
messageFetchResponder, messageFetchResponder,
multimediaMessageCreationResponder, multimediaMessageCreationResponder,
reactionMessageCreationResponder, reactionMessageCreationResponder,
editMessageCreationResponder, editMessageCreationResponder,
▲ Show 20 Lines • Show All 239 Lines • ▼ Show 20 Linesconst jsonEndpoints: { [id: Endpoint]: JSONResponder } = {
update_user_avatar: { update_user_avatar: {
responder: updateUserAvatarResponder, responder: updateUserAvatarResponder,
requiredPolicies: baseLegalPolicies, requiredPolicies: baseLegalPolicies,
}, },
upload_media_metadata: { upload_media_metadata: {
responder: uploadMediaMetadataResponder, responder: uploadMediaMetadataResponder,
requiredPolicies: baseLegalPolicies, requiredPolicies: baseLegalPolicies,
}, },
get_olm_session_initialization_data: {
responder: getOlmSessionInitializationDataResponder,
requiredPolicies: [],
},
}; };
export { jsonEndpoints }; export { jsonEndpoints };
View Options

native/chat/robotext-message-tooltip-button.react.js

Show All 12 Linesimport {
entryRevisionFetchResponder, entryRevisionFetchResponder,
entryCreationResponder, entryCreationResponder,
entryUpdateResponder, entryUpdateResponder,
entryDeletionResponder, entryDeletionResponder,
entryRestorationResponder, entryRestorationResponder,
calendarQueryUpdateResponder, calendarQueryUpdateResponder,
} from './responders/entry-responders.js'; } from './responders/entry-responders.js';
import type { JSONResponder } from './responders/handlers.js'; import type { JSONResponder } from './responders/handlers.js';
import { getSessionPublicKeysResponder } from './responders/keys-responders.js'; import {
getSessionPublicKeysResponder,
getOlmSessionInitializationDataResponder,
} from './responders/keys-responders.js';
import { inviteLinkVerificationResponder } from './responders/link-responders.js'; import { inviteLinkVerificationResponder } from './responders/link-responders.js';
import { messageReportCreationResponder } from './responders/message-report-responder.js'; import { messageReportCreationResponder } from './responders/message-report-responder.js';
import { import {
textMessageCreationResponder, textMessageCreationResponder,
messageFetchResponder, messageFetchResponder,
multimediaMessageCreationResponder, multimediaMessageCreationResponder,
reactionMessageCreationResponder, reactionMessageCreationResponder,
editMessageCreationResponder, editMessageCreationResponder,
▲ Show 20 Lines • Show All 239 Lines • ▼ Show 20 Linesconst jsonEndpoints: { [id: Endpoint]: JSONResponder } = {
update_user_avatar: { update_user_avatar: {
responder: updateUserAvatarResponder, responder: updateUserAvatarResponder,
requiredPolicies: baseLegalPolicies, requiredPolicies: baseLegalPolicies,
}, },
upload_media_metadata: { upload_media_metadata: {
responder: uploadMediaMetadataResponder, responder: uploadMediaMetadataResponder,
requiredPolicies: baseLegalPolicies, requiredPolicies: baseLegalPolicies,
}, },
get_olm_session_initialization_data: {
responder: getOlmSessionInitializationDataResponder,
requiredPolicies: [],
},
}; };
export { jsonEndpoints }; export { jsonEndpoints };
View Options

native/chat/robotext-message.react.js

Show All 12 Linesimport {
entryRevisionFetchResponder, entryRevisionFetchResponder,
entryCreationResponder, entryCreationResponder,
entryUpdateResponder, entryUpdateResponder,
entryDeletionResponder, entryDeletionResponder,
entryRestorationResponder, entryRestorationResponder,
calendarQueryUpdateResponder, calendarQueryUpdateResponder,
} from './responders/entry-responders.js'; } from './responders/entry-responders.js';
import type { JSONResponder } from './responders/handlers.js'; import type { JSONResponder } from './responders/handlers.js';
import { getSessionPublicKeysResponder } from './responders/keys-responders.js'; import {
getSessionPublicKeysResponder,
getOlmSessionInitializationDataResponder,
} from './responders/keys-responders.js';
import { inviteLinkVerificationResponder } from './responders/link-responders.js'; import { inviteLinkVerificationResponder } from './responders/link-responders.js';
import { messageReportCreationResponder } from './responders/message-report-responder.js'; import { messageReportCreationResponder } from './responders/message-report-responder.js';
import { import {
textMessageCreationResponder, textMessageCreationResponder,
messageFetchResponder, messageFetchResponder,
multimediaMessageCreationResponder, multimediaMessageCreationResponder,
reactionMessageCreationResponder, reactionMessageCreationResponder,
editMessageCreationResponder, editMessageCreationResponder,
▲ Show 20 Lines • Show All 239 Lines • ▼ Show 20 Linesconst jsonEndpoints: { [id: Endpoint]: JSONResponder } = {
update_user_avatar: { update_user_avatar: {
responder: updateUserAvatarResponder, responder: updateUserAvatarResponder,
requiredPolicies: baseLegalPolicies, requiredPolicies: baseLegalPolicies,
}, },
upload_media_metadata: { upload_media_metadata: {
responder: uploadMediaMetadataResponder, responder: uploadMediaMetadataResponder,
requiredPolicies: baseLegalPolicies, requiredPolicies: baseLegalPolicies,
}, },
get_olm_session_initialization_data: {
responder: getOlmSessionInitializationDataResponder,
requiredPolicies: [],
},
}; };
export { jsonEndpoints }; export { jsonEndpoints };
View Options

web/chat/robotext-message.react.js

Loading...
View Options

web/modals/chat/toggle-pin-modal.react.js

Loading...
View Options

web/tooltips/message-tooltip.react.js

Loading...
View Options

web/tooltips/tooltip-action-utils.js

Loading...