Page MenuHomePhabricator
Differential D13785

[keyserver] reply on farcaster with invite link
Changes PlannedPublic
Actions

Authored by will on Wed, Oct 23, 11:48 PM.
Tags
None
Referenced Files
F3060035: D13785.id.diff
Thu, Oct 24, 5:25 AM
F3059902: D13785.id45368.diff
Thu, Oct 24, 5:15 AM
F3059898: D13785.id45368.diff
Thu, Oct 24, 5:14 AM
F3059792: D13785.id.diff
Thu, Oct 24, 4:42 AM
F3059770: D13785.id45368.diff
Thu, Oct 24, 4:36 AM
F3059762: D13785.id.diff
Thu, Oct 24, 4:35 AM
F3059756: D13785.diff
Thu, Oct 24, 4:32 AM
F3058982: D13785.diff
Thu, Oct 24, 2:48 AM
Subscribers
tomek

Details

Reviewers
ashoat
varun
Summary

Putting this diff for review. Currently debugging our invalid signerUUID. This diff replies on farcaster with the invite link

Depends on D13784

Test Plan

Will not land until confirm an invite link is posted onto farcaster and properly lets me join a community on my local keyserver

Diff Detail

Repository
rCOMM Comm
Branch
farcaster_bot
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Wed, Oct 23, 11:48 PM
Herald added a subscriber: tomek. · View Herald TranscriptWed, Oct 23, 11:48 PM
will published this revision for review.Wed, Oct 23, 11:51 PM
will added inline comments.
keyserver/src/responders/farcaster-webhook-responders.js
262

Definitely wanted to get an opinion on what we might change this to

Harbormaster completed remote builds in B32363: Diff 45368.Thu, Oct 24, 12:05 AM
tomek added inline comments.Thu, Oct 24, 4:19 AM
keyserver/src/responders/farcaster-webhook-responders.js
262

We shouldn't hardcode the link - instead, we should use inviteLinkURL function.

will planned changes to this revision.Thu, Oct 24, 6:23 AM

Planning changes based on Tomek's feedback

will added inline comments.Thu, Oct 24, 9:48 AM
keyserver/src/responders/farcaster-webhook-responders.js
266

Following discussion at https://linear.app/comm/issue/ENG-8460/create-and-reply-on-farcaster-with-sidebar-invite-link#comment-8582a37a, we'll reply to the tagging cast always

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
23 lines

Diff 45368

View Options

keyserver/src/responders/farcaster-webhook-responders.js

Loading...