Page MenuHomePhabricator
Differential D13783

[keyserver] create invite link based on newly created sidebar
ClosedPublic
Actions

Authored by will on Oct 23 2024, 10:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 1:00 PM
Unknown Object (File)
Thu, Nov 21, 6:52 AM
Unknown Object (File)
Sun, Nov 10, 2:14 PM
Unknown Object (File)
Sat, Nov 9, 9:32 PM
Unknown Object (File)
Fri, Nov 8, 11:06 PM
Unknown Object (File)
Thu, Nov 7, 2:38 AM
Unknown Object (File)
Mon, Nov 4, 12:24 AM
Unknown Object (File)
Sun, Nov 3, 1:41 PM
View All 21 Files
Subscribers
tomek

Details

Reviewers
varun
ashoat
Commits
rCOMMdb09962901fb: [keyserver] create invite link based on newly created sidebar
Summary

This creates an invite link for the newly created sidebar.

Depends on D13782

Test Plan

console logged the invitelink. On my iOS simulator dev build, plugged in the invite link to safari with https://comm.app/invite/<value> and confirmed I successfully joined the community and sidebar with a user originally not in either.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Oct 23 2024, 10:42 PM
Herald added a subscriber: tomek. · View Herald TranscriptOct 23 2024, 10:42 PM
will edited the summary of this revision. (Show Details)Oct 23 2024, 10:42 PM
will added a parent revision: D13782: [keyserver] create message and sidebar based on cast.
will removed a parent revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 23 2024, 10:46 PM
Harbormaster failed remote builds in B32360: Diff 45365!
will added a child revision: D13784: [lib] add post cast to neynar client.Oct 23 2024, 11:43 PM
will requested review of this revision.Oct 23 2024, 11:45 PM
Harbormaster completed remote builds in B32360: Diff 45365.Oct 23 2024, 11:47 PM
will added inline comments.Thu, Oct 24, 6:18 AM
keyserver/src/responders/farcaster-webhook-responders.js
255 ↗(On Diff #45365)

Placeholder to be used in replying to cast

ashoat accepted this revision.Thu, Oct 24, 6:22 AM
ashoat added inline comments.
keyserver/src/responders/farcaster-webhook-responders.js
247 ↗(On Diff #45365)

Seems like you call this 3 times in this file.

Why not lift it to the top-level scope so it can be called just once?

This revision is now accepted and ready to land.Thu, Oct 24, 6:22 AM
will added a parent revision: D13812: [keyserver] Add dontCheckJoinPermissions override option to createThread for sidebar.Tue, Oct 29, 4:37 PM
will removed a parent revision: D13812: [keyserver] Add dontCheckJoinPermissions override option to createThread for sidebar.
will added inline comments.Wed, Oct 30, 1:47 PM
keyserver/src/responders/farcaster-webhook-responders.js
247 ↗(On Diff #45365)

Included in a rebase of https://phab.comm.dev/D13775

ashoat added inline comments.Wed, Oct 30, 2:53 PM
keyserver/src/responders/farcaster-webhook-responders.js
247 ↗(On Diff #45365)

This diff depends on that one, though... don't you need to update this diff too? I would expect to see an updated version of this diff that doesn't introduce a new commbotViewer

will updated this revision to Diff 45497.Wed, Oct 30, 7:10 PM

rebase

Harbormaster completed remote builds in B32464: Diff 45497.Wed, Oct 30, 7:27 PM
Closed by commit rCOMMdb09962901fb: [keyserver] create invite link based on newly created sidebar (authored by will). · Explain WhyThu, Oct 31, 12:19 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMMdb09962901fb: [keyserver] create invite link based on newly created sidebar.

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
10 lines

Diff 45497

View Options

keyserver/src/responders/farcaster-webhook-responders.js

Loading...