Putting this diff for review. Currently debugging our invalid signerUUID. This diff replies on farcaster with the invite link
Depends on D13784
Details
Details
Tested with my local iOS simulator comm app. I grabbed the invite link posted to warpcast and pasted it to my safari. Was able to successfully join new communities and/or sidebars
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- farcaster_bot
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| keyserver/src/responders/farcaster-webhook-responders.js | ||
|---|---|---|
| 262 ↗ | (On Diff #45368) | Definitely wanted to get an opinion on what we might change this to |
| keyserver/src/responders/farcaster-webhook-responders.js | ||
|---|---|---|
| 262 ↗ | (On Diff #45368) | We shouldn't hardcode the link - instead, we should use inviteLinkURL function. |
| keyserver/src/responders/farcaster-webhook-responders.js | ||
|---|---|---|
| 266 ↗ | (On Diff #45368) | Following discussion at https://linear.app/comm/issue/ENG-8460/create-and-reply-on-farcaster-with-sidebar-invite-link#comment-8582a37a, we'll reply to the tagging cast always |
| keyserver/src/responders/farcaster-webhook-responders.js | ||
|---|---|---|
| 262 ↗ | (On Diff #45368) | Starting a linear conversation on what this might look like: |
| keyserver/src/responders/farcaster-webhook-responders.js | ||
|---|---|---|
| 286 ↗ | (On Diff #45488) | Why do we wait until this point to start this promise? |
| 288–290 ↗ | (On Diff #45488) | Please keep all lines to a max of 80 chars |
| 292–294 ↗ | (On Diff #45488) | I'd probably move it higher |
| 296 ↗ | (On Diff #45488) |
|
| 297 ↗ | (On Diff #45488) | Doesn't the condition on line 292 mean we have a signerUUID? |
| 302 ↗ | (On Diff #45488) | Do we need the question mark? |
| keyserver/src/responders/farcaster-webhook-responders.js | ||
|---|---|---|
| 286 ↗ | (On Diff #45488) | Addressed by moving up higher as a promise |
| 292–294 ↗ | (On Diff #45488) | Ended up moving it higher as a promise but kept the missing_signer_uuid check at the same spot as I don't think we're expecting this to happen |
| 297 ↗ | (On Diff #45488) | This is correct. Removing ? |
| 302 ↗ | (On Diff #45488) | Looks like we do. Flow complains if I remove it and says its type is void | NeynarPostCastResponse |
| keyserver/src/responders/farcaster-webhook-responders.js | ||
|---|---|---|
| 296 ↗ | (On Diff #45488) | Confused. 292 is for neynarConfig right? I found several examples in the codebase of using it as neynarClient?.method |