[keyserver] Run num admin change checks in updateRole only if intended role is not an admin
ClosedPublic
Actions

Authored by will on Wed, Oct 30, 1:00 PM.

Details

Reviewers

ashoat
varun

Commits

rCOMM18fbb1159924: [keyserver] Run num admin change checks in updateRole only if intended role is…

Summary

Ran into an issue with running updateRole with a ghost commbot viewer to set the communityAdminID for createTaggedFarcasterCommunity causing a invalid_parameters as the changed admin count was equal to the current number of community admins.
This diff allows us to skip over this check if the request is to change members to admins

Depends on D13833

Test Plan

Was able to successfully update the role for the prospective comm user admin to an actual admin as confirmed by the iOS simualtor's chat list without encountering invalid_parameters.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Wed, Oct 30, 1:00 PM

Herald added a subscriber: tomek. · View Herald TranscriptWed, Oct 30, 1:00 PM

will added a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Wed, Oct 30, 1:31 PM

Harbormaster completed remote builds in B32451: Diff 45484.Wed, Oct 30, 1:47 PM

will requested review of this revision.Wed, Oct 30, 1:47 PM

will retitled this revision from [keyserver] Run num admin change checks in updateRole only if request is not by an admin to [keyserver] Run num admin change checks in updateRole only if intended role is not an admin.Wed, Oct 30, 2:18 PM

ashoat accepted this revision.Wed, Oct 30, 2:41 PM

This revision is now accepted and ready to land.Wed, Oct 30, 2:41 PM

rebase

Harbormaster completed remote builds in B32492: Diff 45526.Thu, Oct 31, 10:31 AM

Closed by commit rCOMM18fbb1159924: [keyserver] Run num admin change checks in updateRole only if intended role is… (authored by will). · Explain WhyThu, Oct 31, 12:19 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM18fbb1159924: [keyserver] Run num admin change checks in updateRole only if intended role is….