Page MenuHomePhabricator
Differential D13781

[keyserver] add comm config for authoritative facaster bot boolean variable
ClosedPublic
Actions

Authored by will on Oct 23 2024, 9:19 PM.
Tags
None
Referenced Files
F3385423: D13781.id45362.diff
Fri, Nov 29, 12:17 AM
F3385109: D13781.id45555.diff
Thu, Nov 28, 11:28 PM
Unknown Object (File)
Mon, Nov 25, 7:14 AM
Unknown Object (File)
Sat, Nov 23, 3:14 AM
Unknown Object (File)
Wed, Nov 13, 5:55 PM
Unknown Object (File)
Tue, Nov 12, 10:46 PM
Unknown Object (File)
Tue, Nov 12, 7:48 PM
Unknown Object (File)
Tue, Nov 12, 8:59 AM
View All 36 Files
Subscribers
tomek

Details

Reviewers
ashoat
varun
Commits
rCOMM2ba2879020f9: [keyserver] add comm config for authoritative facaster bot boolean variable
Summary

Adds a farcaster bot config to facts which includes a boolean value for authoritativeFarcasterBot which decides whether or not we create a farcaster channel tagged community if not already existent or create a sidebar when a channel isn't specified.

Depends on D13774

Test Plan

Tested later in the stack by setting to true and ensured tagged communities were being created properly

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will created this revision.Oct 23 2024, 9:19 PM
Herald added a subscriber: tomek. · View Herald TranscriptOct 23 2024, 9:19 PM
will added a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Oct 23 2024, 9:20 PM
will mentioned this in D13775: [keyserver] add community creation logic to farcaster webhook responder.Oct 23 2024, 9:24 PM
Harbormaster completed remote builds in B32357: Diff 45362.Oct 23 2024, 9:37 PM
will requested review of this revision.Oct 23 2024, 9:37 PM
ashoat accepted this revision.Oct 24 2024, 5:56 AM
This revision is now accepted and ready to land.Oct 24 2024, 5:56 AM
ashoat added inline comments.Oct 24 2024, 6:11 AM
keyserver/src/utils/farcaster-bot.js
9 ↗(On Diff #45362)

Let's return a different type here where authoritativeFarcasterBot isn't optional

will updated this revision to Diff 45420.Oct 28 2024, 3:00 PM
will marked an inline comment as done.

review feedback

keyserver/src/utils/farcaster-bot.js
9 ↗(On Diff #45362)

Included in rebase

Harbormaster completed remote builds in B32398: Diff 45420.Oct 28 2024, 3:42 PM
will added a child revision: D13811: [keyserver] add function to grab comm userID for given fid if on keyserver.Oct 29 2024, 2:23 PM
will removed a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.
Closed by commit rCOMM2ba2879020f9: [keyserver] add comm config for authoritative facaster bot boolean variable (authored by will). · Explain WhyThu, Oct 31, 12:19 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM2ba2879020f9: [keyserver] add comm config for authoritative facaster bot boolean variable.

Revision Contents
Changeset List

PathSize
keyserver/
src/
utils/
24 lines

Diff 45555

View Options

keyserver/src/utils/farcaster-bot.js

Loading...