Page MenuHomePhabricator

[lib] Do not reset a session when getting already decrypted message
ClosedPublic

Authored by angelika on Nov 8 2024, 8:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 21, 2:55 AM
Unknown Object (File)
Wed, Feb 12, 7:50 PM
Unknown Object (File)
Wed, Feb 12, 7:50 PM
Unknown Object (File)
Wed, Feb 12, 7:50 PM
Unknown Object (File)
Wed, Feb 12, 7:50 PM
Unknown Object (File)
Wed, Feb 12, 7:50 PM
Unknown Object (File)
Wed, Feb 12, 7:50 PM
Unknown Object (File)
Wed, Feb 12, 7:50 PM
Subscribers

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

lib/tunnelbroker/use-peer-to-peer-message-handler.js
334 ↗(On Diff #45725)

Nit

kamil added inline comments.
lib/utils/olm-utils.js
131 ↗(On Diff #45725)

following other errors here, might be worth adding a comment from Olm about what the error means - but on the other hand error is self descriptive so up to you

This revision is now accepted and ready to land.Nov 12 2024, 5:00 AM
lib/tunnelbroker/use-peer-to-peer-message-handler.js
334 ↗(On Diff #45744)

Reminder about nit

lib/tunnelbroker/use-peer-to-peer-message-handler.js
334 ↗(On Diff #45787)

Nit was not addressed even though I mentioned it twice

lib/utils/olm-utils.js
131 ↗(On Diff #45787)

Also noticed this line exceeds the 80 char limit. Please keep all lines (including string literals and comments) to a max of 80 chars. Only exception is when Prettier forces it (only applies to imports)