Page MenuHomePhabricator
Differential D13901

[lib] Do not reset a session when getting already decrypted message
ClosedPublic
Actions

Authored by angelika on Nov 8 2024, 8:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 15, 2:13 AM
Unknown Object (File)
Sat, Mar 15, 2:13 AM
Unknown Object (File)
Sat, Mar 15, 2:13 AM
Unknown Object (File)
Sat, Mar 15, 2:13 AM
Unknown Object (File)
Sat, Mar 15, 2:13 AM
Unknown Object (File)
Sat, Mar 15, 2:13 AM
Unknown Object (File)
Sat, Mar 15, 2:13 AM
Unknown Object (File)
Wed, Mar 12, 9:21 AM
View All 84 Files
Subscribers
ashoat

Details

Reviewers
tomek
kamil
Commits
rCOMM5759f0fb35b6: [lib] Do not reset a session when getting already decrypted message
Summary

https://linear.app/comm/issue/ENG-9713/mitigate-risk-of-olm-already-decrypted-or-keys-skipped

Depends on D13900

Test Plan

This scenario is hard to reproduce normally (tunnelbroker connection needs to be broken in just the right moment)
so:

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

angelika created this revision.Nov 8 2024, 8:07 AM
Herald added a subscriber: ashoat. · View Herald TranscriptNov 8 2024, 8:07 AM
Harbormaster completed remote builds in B32596: Diff 45725.Nov 8 2024, 8:32 AM
angelika requested review of this revision.Nov 8 2024, 8:32 AM
ashoat added inline comments.Nov 8 2024, 8:52 AM
lib/tunnelbroker/use-peer-to-peer-message-handler.js
334 ↗(On Diff #45725)

Nit

angelika edited the test plan for this revision. (Show Details)Nov 12 2024, 4:33 AM
kamil accepted this revision.Nov 12 2024, 5:00 AM
kamil added inline comments.
lib/utils/olm-utils.js
131 ↗(On Diff #45725)

following other errors here, might be worth adding a comment from Olm about what the error means - but on the other hand error is self descriptive so up to you

This revision is now accepted and ready to land.Nov 12 2024, 5:00 AM
angelika updated this revision to Diff 45739.Nov 12 2024, 5:28 AM

Add space

Harbormaster failed remote builds in B32605: Diff 45739!Nov 12 2024, 5:42 AM
angelika updated this revision to Diff 45744.Nov 12 2024, 5:45 AM

Rebase

Harbormaster failed remote builds in B32610: Diff 45744!Nov 12 2024, 6:04 AM
ashoat added inline comments.Nov 12 2024, 6:50 AM
lib/tunnelbroker/use-peer-to-peer-message-handler.js
334 ↗(On Diff #45744)

Reminder about nit

angelika updated this revision to Diff 45754.Nov 12 2024, 7:36 AM

Rebase

Harbormaster completed remote builds in B32618: Diff 45754.Nov 12 2024, 8:04 AM
Closed by commit rCOMM5759f0fb35b6: [lib] Do not reset a session when getting already decrypted message (authored by angelika). · Explain WhyNov 13 2024, 4:17 AM
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMM5759f0fb35b6: [lib] Do not reset a session when getting already decrypted message.
ashoat added inline comments.Nov 13 2024, 5:59 AM
lib/tunnelbroker/use-peer-to-peer-message-handler.js
334 ↗(On Diff #45787)

Nit was not addressed even though I mentioned it twice

lib/utils/olm-utils.js
131 ↗(On Diff #45787)

Also noticed this line exceeds the 80 char limit. Please keep all lines (including string literals and comments) to a max of 80 chars. Only exception is when Prettier forces it (only applies to imports)

angelika mentioned this in D13923: [lib] Fix capitalization in usePeerToPeerMessageHandler.Nov 13 2024, 6:42 AM
angelika mentioned this in D13924: [lib] Fix long line in olmSessionErrors.Nov 13 2024, 6:47 AM
angelika mentioned this in rCOMMf7cf29b804d1: [lib] Fix capitalization in usePeerToPeerMessageHandler.Nov 13 2024, 11:24 AM
angelika mentioned this in rCOMM3e5fbff299f3: [lib] Fix long line in olmSessionErrors.Nov 13 2024, 11:27 AM

Revision Contents
Changeset List

PathSize
lib/
tunnelbroker/
15 lines
utils/
1 line

Diff 45739

View Options

lib/tunnelbroker/use-peer-to-peer-message-handler.js

Show First 20 Lines • Show All 51 Lines • ▼ Show 20 Lines
import ChatContextProvider from './chat/chat-context-provider.react.js'; import ChatContextProvider from './chat/chat-context-provider.react.js';
import MessageEditingContextProvider from './chat/message-editing-context-provider.react.js'; import MessageEditingContextProvider from './chat/message-editing-context-provider.react.js';
import AccessTokenHandler from './components/access-token-handler.react.js'; import AccessTokenHandler from './components/access-token-handler.react.js';
import { AutoJoinCommunityHandler } from './components/auto-join-community-handler.react.js'; import { AutoJoinCommunityHandler } from './components/auto-join-community-handler.react.js';
import BackgroundIdentityLoginHandler from './components/background-identity-login-handler.react.js'; import BackgroundIdentityLoginHandler from './components/background-identity-login-handler.react.js';
import ConnectFarcasterAlertHandler from './components/connect-farcaster-alert-handler.react.js'; import ConnectFarcasterAlertHandler from './components/connect-farcaster-alert-handler.react.js';
import DMActivityHandler from './components/dm-activity-handler.react.js'; import DMActivityHandler from './components/dm-activity-handler.react.js';
import { FeatureFlagsProvider } from './components/feature-flags-provider.react.js'; import { FeatureFlagsProvider } from './components/feature-flags-provider.react.js';
import JoinCommunityAlertHandler from './components/join-community-alert-handler.react.js';
import { NUXTipsContextProvider } from './components/nux-tips-context.react.js'; import { NUXTipsContextProvider } from './components/nux-tips-context.react.js';
import PersistedStateGate from './components/persisted-state-gate.js'; import PersistedStateGate from './components/persisted-state-gate.js';
import ReportHandler from './components/report-handler.react.js'; import ReportHandler from './components/report-handler.react.js';
import VersionSupportedChecker from './components/version-supported.react.js'; import VersionSupportedChecker from './components/version-supported.react.js';
import ConnectedStatusBar from './connected-status-bar.react.js'; import ConnectedStatusBar from './connected-status-bar.react.js';
import { SQLiteDataHandler } from './data/sqlite-data-handler.js'; import { SQLiteDataHandler } from './data/sqlite-data-handler.js';
import ErrorBoundary from './error-boundary.react.js'; import ErrorBoundary from './error-boundary.react.js';
import IdentityServiceContextProvider from './identity-service/identity-service-context-provider.react.js'; import IdentityServiceContextProvider from './identity-service/identity-service-context-provider.react.js';
▲ Show 20 Lines • Show All 242 Lines • ▼ Show 20 Lines navigation = (
<NUXTipsContextProvider> <NUXTipsContextProvider>
<RootNavigator /> <RootNavigator />
</NUXTipsContextProvider> </NUXTipsContextProvider>
</ChatMentionContextProvider> </ChatMentionContextProvider>
</DeepLinksContextProvider> </DeepLinksContextProvider>
</ChatContextProvider> </ChatContextProvider>
<NavigationHandler /> <NavigationHandler />
<PersistedStateGate> <PersistedStateGate>
<JoinCommunityAlertHandler />
<FarcasterDataHandler> <FarcasterDataHandler>
<ConnectFarcasterAlertHandler /> <ConnectFarcasterAlertHandler />
</FarcasterDataHandler> </FarcasterDataHandler>
</PersistedStateGate> </PersistedStateGate>
</BottomSheetModalProvider> </BottomSheetModalProvider>
</NavigationContainer> </NavigationContainer>
); );
} }
▲ Show 20 Lines • Show All 107 Lines • Show Last 20 Lines
View Options

lib/utils/olm-utils.js

Show First 20 Lines • Show All 51 Lines • ▼ Show 20 Lines
import ChatContextProvider from './chat/chat-context-provider.react.js'; import ChatContextProvider from './chat/chat-context-provider.react.js';
import MessageEditingContextProvider from './chat/message-editing-context-provider.react.js'; import MessageEditingContextProvider from './chat/message-editing-context-provider.react.js';
import AccessTokenHandler from './components/access-token-handler.react.js'; import AccessTokenHandler from './components/access-token-handler.react.js';
import { AutoJoinCommunityHandler } from './components/auto-join-community-handler.react.js'; import { AutoJoinCommunityHandler } from './components/auto-join-community-handler.react.js';
import BackgroundIdentityLoginHandler from './components/background-identity-login-handler.react.js'; import BackgroundIdentityLoginHandler from './components/background-identity-login-handler.react.js';
import ConnectFarcasterAlertHandler from './components/connect-farcaster-alert-handler.react.js'; import ConnectFarcasterAlertHandler from './components/connect-farcaster-alert-handler.react.js';
import DMActivityHandler from './components/dm-activity-handler.react.js'; import DMActivityHandler from './components/dm-activity-handler.react.js';
import { FeatureFlagsProvider } from './components/feature-flags-provider.react.js'; import { FeatureFlagsProvider } from './components/feature-flags-provider.react.js';
import JoinCommunityAlertHandler from './components/join-community-alert-handler.react.js';
import { NUXTipsContextProvider } from './components/nux-tips-context.react.js'; import { NUXTipsContextProvider } from './components/nux-tips-context.react.js';
import PersistedStateGate from './components/persisted-state-gate.js'; import PersistedStateGate from './components/persisted-state-gate.js';
import ReportHandler from './components/report-handler.react.js'; import ReportHandler from './components/report-handler.react.js';
import VersionSupportedChecker from './components/version-supported.react.js'; import VersionSupportedChecker from './components/version-supported.react.js';
import ConnectedStatusBar from './connected-status-bar.react.js'; import ConnectedStatusBar from './connected-status-bar.react.js';
import { SQLiteDataHandler } from './data/sqlite-data-handler.js'; import { SQLiteDataHandler } from './data/sqlite-data-handler.js';
import ErrorBoundary from './error-boundary.react.js'; import ErrorBoundary from './error-boundary.react.js';
import IdentityServiceContextProvider from './identity-service/identity-service-context-provider.react.js'; import IdentityServiceContextProvider from './identity-service/identity-service-context-provider.react.js';
▲ Show 20 Lines • Show All 242 Lines • ▼ Show 20 Lines navigation = (
<NUXTipsContextProvider> <NUXTipsContextProvider>
<RootNavigator /> <RootNavigator />
</NUXTipsContextProvider> </NUXTipsContextProvider>
</ChatMentionContextProvider> </ChatMentionContextProvider>
</DeepLinksContextProvider> </DeepLinksContextProvider>
</ChatContextProvider> </ChatContextProvider>
<NavigationHandler /> <NavigationHandler />
<PersistedStateGate> <PersistedStateGate>
<JoinCommunityAlertHandler />
<FarcasterDataHandler> <FarcasterDataHandler>
<ConnectFarcasterAlertHandler /> <ConnectFarcasterAlertHandler />
</FarcasterDataHandler> </FarcasterDataHandler>
</PersistedStateGate> </PersistedStateGate>
</BottomSheetModalProvider> </BottomSheetModalProvider>
</NavigationContainer> </NavigationContainer>
); );
} }
▲ Show 20 Lines • Show All 107 Lines • Show Last 20 Lines