Details
Details
This scenario is hard to reproduce normally (tunnelbroker connection needs to be broken in just the right moment)
so:
- test on both native and web, the steps are the same
- comment out this code: https://github.com/CommE2E/comm/blob/9360b1f7fff5269dd3b56af42dc711045d546cca/lib/tunnelbroker/use-confirm-peer-to-peer-message.js#L39-L43 and this code: https://github.com/CommE2E/comm/blob/9360b1f7fff5269dd3b56af42dc711045d546cca/lib/tunnelbroker/peer-to-peer-message-handler.js#L94
- send a message
- restart/refresh the app
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/tunnelbroker/use-peer-to-peer-message-handler.js | ||
|---|---|---|
| 334 ↗ | (On Diff #45725) | Nit |
| lib/utils/olm-utils.js | ||
|---|---|---|
| 131 ↗ | (On Diff #45725) | following other errors here, might be worth adding a comment from Olm about what the error means - but on the other hand error is self descriptive so up to you |
| lib/tunnelbroker/use-peer-to-peer-message-handler.js | ||
|---|---|---|
| 334 | Reminder about nit | |
| lib/tunnelbroker/use-peer-to-peer-message-handler.js | ||
|---|---|---|
| 334 ↗ | (On Diff #45787) | Nit was not addressed even though I mentioned it twice |
| lib/utils/olm-utils.js | ||
| 131 ↗ | (On Diff #45787) | Also noticed this line exceeds the 80 char limit. Please keep all lines (including string literals and comments) to a max of 80 chars. Only exception is when Prettier forces it (only applies to imports) |