Page MenuHomePhabricator
Differential D13897

[sqlite] Add getInboundP2PMessagesByID query
ClosedPublic
Actions

Authored by angelika on Nov 8 2024, 7:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 5:23 PM
Unknown Object (File)
Wed, Dec 18, 2:04 PM
Unknown Object (File)
Fri, Dec 13, 11:16 PM
Unknown Object (File)
Fri, Dec 13, 11:15 PM
Unknown Object (File)
Fri, Dec 13, 11:09 PM
Unknown Object (File)
Tue, Dec 10, 1:19 AM
Unknown Object (File)
Thu, Nov 28, 3:03 AM
Unknown Object (File)
Nov 22 2024, 5:46 AM
View All 19 Files
Subscribers
ashoat

Details

Reviewers
tomek
kamil
Commits
rCOMM224d94fb7a6e: [sqlite] Add getInboundP2PMessagesByID query
Summary

https://linear.app/comm/issue/ENG-9713/mitigate-risk-of-olm-already-decrypted-or-keys-skipped

Test Plan

Test plan in the last diff in stack.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

angelika created this revision.Nov 8 2024, 7:51 AM
Herald added a subscriber: ashoat. · View Herald TranscriptNov 8 2024, 7:51 AM
angelika added a child revision: D13898: [web] Implement getInboundP2PMessagesByID query on worker.Nov 8 2024, 7:52 AM
Harbormaster completed remote builds in B32592: Diff 45721.Nov 8 2024, 8:14 AM
angelika requested review of this revision.Nov 8 2024, 8:14 AM
kamil accepted this revision.Nov 12 2024, 2:42 AM
kamil added inline comments.
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2752 ↗(On Diff #45721)
2753–2754 ↗(On Diff #45721)

nit: match indentation with other queries here

This revision is now accepted and ready to land.Nov 12 2024, 2:42 AM
angelika updated this revision to Diff 45735.Nov 12 2024, 4:50 AM

Formatting

kamil added inline comments.Nov 12 2024, 5:03 AM
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2753–2757 ↗(On Diff #45735)

it needs to be 2-spaces to match other queries

Harbormaster failed remote builds in B32601: Diff 45735!Nov 12 2024, 5:06 AM
angelika updated this revision to Diff 45740.Nov 12 2024, 5:44 AM

Run emscripten

Harbormaster completed remote builds in B32606: Diff 45740.Nov 12 2024, 6:10 AM
Closed by commit rCOMM224d94fb7a6e: [sqlite] Add getInboundP2PMessagesByID query (authored by angelika). · Explain WhyNov 13 2024, 4:17 AM
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMM224d94fb7a6e: [sqlite] Add getInboundP2PMessagesByID query.
ashoat added inline comments.Nov 13 2024, 5:49 AM
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2753–2757 ↗(On Diff #45735)

Kamil's feedback here was not addressed

angelika mentioned this in D13922: [sqlite] Add missing spaces in getInboundP2PMessagesByID query.Nov 13 2024, 6:15 AM
angelika mentioned this in rCOMMadd745dbaf17: [sqlite] Add missing spaces in getInboundP2PMessagesByID query.Nov 13 2024, 11:22 AM

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
2 lines
2 lines
20 lines
web/
cpp/
3 lines
shared-worker/
_generated/
queries/
6 lines
types/
3 lines

Diff 45740

View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...
View Options

web/cpp/SQLiteQueryExecutorBindings.cpp

Loading...
View Options

web/shared-worker/_generated/comm_query_executor.wasm

Loading...
View Options

web/shared-worker/queries/inbound-p2p-message-queries.test.js

Loading...
View Options

web/shared-worker/types/sqlite-query-executor.js

Loading...