Page MenuHomePhabricator
Differential D13942

[backup] add errorType to error logs in backup
ClosedPublic
Actions

Authored by will on Thu, Nov 14, 8:45 PM.
Tags
None
Referenced Files
F3385683: D13942.id45838.diff
Fri, Nov 29, 1:39 AM
F3385582: D13942.id45840.diff
Fri, Nov 29, 1:06 AM
F3385078: D13942.id45833.diff
Thu, Nov 28, 11:17 PM
F3385010: D13942.id45838.diff
Thu, Nov 28, 11:02 PM
F3384476: D13942.diff
Thu, Nov 28, 9:08 PM
F3383841: D13942.id45839.diff
Thu, Nov 28, 6:00 PM
F3383653: D13942.id45834.diff
Thu, Nov 28, 5:11 PM
F3382816: D13942.id45833.diff
Thu, Nov 28, 12:07 PM
View All 36 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
bartek
Commits
rCOMM3d2db7642854: [backup] add errorType to error logs in backup
Summary

Add errorTypes to errors logs in backup service.

This includes:

  • DDB Error
  • Auth Error
  • Blob Error
  • WS Error

Depends on D13941

Test Plan

Deployed to staging. Verified that JSON error logs on cloudwatch include errorType

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will created this revision.Thu, Nov 14, 8:45 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Nov 14, 8:45 PM
will added a child revision: D13943: [terraform] break up alarms into separate terraform files.Thu, Nov 14, 8:52 PM
will retitled this revision from [backup] add errorType logs to backup to [backup] add errorType to error logs in backup.Thu, Nov 14, 8:53 PM
will mentioned this in D13944: [terraform] create backup cloudwatch alarms.Thu, Nov 14, 8:57 PM
Harbormaster completed remote builds in B32674: Diff 45833.Thu, Nov 14, 9:03 PM
will requested review of this revision.Thu, Nov 14, 9:03 PM
bartek accepted this revision.Fri, Nov 15, 2:16 AM
bartek added 1 blocking reviewer(s): kamil.
kamil accepted this revision.Fri, Nov 15, 2:17 AM
kamil added 1 blocking reviewer(s): bartek.

LGTM but @bartek should review this too

bartek accepted this revision.Fri, Nov 15, 2:18 AM
This revision is now accepted and ready to land.Fri, Nov 15, 2:18 AM
Closed by commit rCOMM3d2db7642854: [backup] add errorType to error logs in backup (authored by will). · Explain WhyFri, Nov 15, 9:53 AM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM3d2db7642854: [backup] add errorType to error logs in backup.
will mentioned this in rCOMM9fe6ac4e8124: [terraform] create backup cloudwatch alarms.Mon, Nov 18, 4:54 AM

Revision Contents
Changeset List

PathSize
services/
backup/
src/
9 lines
database/
34 lines
17 lines
http/
handlers/
7 lines

Diff 45838

View Options

services/backup/src/constants.rs

Loading...
View Options

services/backup/src/database/mod.rs

Loading...
View Options

services/backup/src/error.rs

Loading...
View Options

services/backup/src/http/handlers/log.rs

Loading...