Paths

Table of Contentst

[lib] Don't query Neynar for Farcaster channel avatars if unused
ClosedPublic
Actions

Authored by ashoat on Nov 20 2024, 6:48 AM.

Details

Reviewers

varun
will

Commits

rCOMM4d11d51c931e: [lib] Don't query Neynar for Farcaster channel avatars if unused

Summary

This eliminates most fetches, since we mostly aren't using Farcaster channel avatars yet.

Depends on D13982

Test Plan

In combination with other diffs, tested that channel avatars still load on both web and native
Tested on both native and web by logging each NeynarClient query and seeing which ones get triggered

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/diff

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Nov 20 2024, 6:48 AM

Herald added a subscriber: tomek. · View Herald TranscriptNov 20 2024, 6:48 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 20 2024, 7:06 AM

Harbormaster failed remote builds in B32733: Diff 45907!

Rebase

ashoat published this revision for review.Nov 20 2024, 7:16 AM

Fix rebase mistake

Harbormaster completed remote builds in B32736: Diff 45910.Nov 20 2024, 8:25 AM

Harbormaster completed remote builds in B32737: Diff 45911.Nov 20 2024, 8:33 AM

will accepted this revision.Nov 20 2024, 2:32 PM

This revision is now accepted and ready to land.Nov 20 2024, 2:32 PM

Closed by commit rCOMM4d11d51c931e: [lib] Don't query Neynar for Farcaster channel avatars if unused (authored by ashoat). · Explain WhyNov 22 2024, 6:13 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM4d11d51c931e: [lib] Don't query Neynar for Farcaster channel avatars if unused.

Revision Contents
Changeset List

Path

Size

lib/

components/

farcaster-channel-prefetch-handler.react.js

18 lines

shared/

avatar-utils.js

6 lines

Diff 45911

View Options

lib/components/farcaster-channel-prefetch-handler.react.js