[native] implement Restore protocol for Signed Device List
ClosedPublic
Actions

Authored by kamil on Thu, Dec 5, 4:39 AM.

Details

Reviewers

bartek
tomek
varun

Commits

rCOMMc20f2b65d0b4: [native] implement Restore protocol for Signed Device List

Summary

ENG-8195.

This is a generic hook, used for both password and wallet users.

Do all the steps without what's marked with a red line at the bottom (this is the Full Backup version, not ready yet):

Screenshot 2024-12-06 at 11.11.25.png (1×615 px, 213 KB)

For the Signed Device Lists, we also need this part:

It's tracked in ENG-8200

Depends on D14081

Test Plan

Flow, logic tested later in the stack

Diff Detail

Repository

rCOMM Comm

Branch

restore

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Thu, Dec 5, 4:39 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptThu, Dec 5, 4:39 AM

kamil added a child revision: D14083: [native] implement hook for restore.Thu, Dec 5, 4:46 AM

Harbormaster completed remote builds in B32934: Diff 46218.Thu, Dec 5, 4:57 AM

improve naming

kamil retitled this revision from [native] implement hook for restore protocol to [native] implement Restore protocol for Signed Device List.Fri, Dec 6, 1:34 AM

Harbormaster completed remote builds in B32942: Diff 46226.Fri, Dec 6, 1:54 AM

kamil published this revision for review.Fri, Dec 6, 2:15 AM

kamil edited the summary of this revision. (Show Details)

kamil added inline comments.Fri, Dec 6, 2:19 AM

native/account/restore.js
54–55 ↗	(On Diff #46226)	`retrieveLatestBackupInfo` also returns `siweBackupData`, for SIWE, we want this before running this hook (we need to sign this message to get a signature, which is used as a secret here). We might want to move this call earlier and pass `userID` and `backupID` as params to avoid calling `retrieveLatestBackupInfo` twice, but this could be done later when the full restore flow is ready.

ashoat added inline comments.Sat, Dec 7, 12:47 PM

native/account/restore.js
35 ↗	(On Diff #46226)	Nit

tomek accepted this revision.Wed, Dec 11, 2:38 AM

tomek added inline comments.

native/account/restore.js
21–27 ↗	(On Diff #46226)	How about making it typed more strongly by requiring that message and signature are present for SIWE? `{type:'password', username: string, password: string} \| {type:'siwe', address: string, secret: string, message: string, signature:string}`?

This revision is now accepted and ready to land.Wed, Dec 11, 2:38 AM

kamil added inline comments.Wed, Dec 11, 5:03 AM

native/account/restore.js
21–27 ↗	(On Diff #46226)	As discussed in the office, I am going to leave it as it is, and if needed,d @tomek will update this when connected this with UI