Details
Details
Flow, logic tested later in the stack
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/account/restore.js | ||
|---|---|---|
| 54–55 | retrieveLatestBackupInfo also returns siweBackupData, for SIWE, we want this before running this hook (we need to sign this message to get a signature, which is used as a secret here). We might want to move this call earlier and pass userID and backupID as params to avoid calling retrieveLatestBackupInfo twice, but this could be done later when the full restore flow is ready. | |
| native/account/restore.js | ||
|---|---|---|
| 35 | Nit | |
| native/account/restore.js | ||
|---|---|---|
| 21–27 | How about making it typed more strongly by requiring that message and signature are present for SIWE? {type:'password', username: string, password: string} | {type:'siwe', address: string, secret: string, message: string, signature:string}? | |