Page MenuHomePhabricator

[native] implement hook for restore
ClosedPublic

Authored by kamil on Thu, Dec 5, 4:46 AM.
Tags
None
Referenced Files
F3528015: D14083.diff
Tue, Dec 24, 7:48 AM
Unknown Object (File)
Mon, Dec 23, 6:56 PM
Unknown Object (File)
Sat, Dec 21, 3:30 PM
Unknown Object (File)
Sat, Dec 21, 3:12 AM
Unknown Object (File)
Fri, Dec 20, 11:55 PM
Unknown Object (File)
Fri, Dec 20, 9:58 PM
Unknown Object (File)
Fri, Dec 20, 9:34 PM
Unknown Object (File)
Fri, Dec 20, 10:45 AM
Subscribers

Details

Summary

ENG-8195.

Implementing a hook for user restore, similar to the password/wallet user login.

Depends on D14082

Test Plan
  1. Use this hook in LogInPanel instead of usePasswordLogIn.
  2. Add a bunch of logs.
  3. Register a new Account and add a different user as a friend.
  4. Log out using v2.
  5. Log in (which executed restore).
  6. Look at logs - all steps passed.
  7. The user is visually logged in, and everything works.
  8. On other user observer logs, the device list is updated, but it's not passing validation (which is expected because of D14079). After D14079 is deployed, validation should pass.

EDIT: Tested after Identity deploy, it works!

image.png (308×837 px, 114 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil retitled this revision from [native] implement hook for password restore to [native] implement hook for restore.Fri, Dec 6, 1:39 AM
kamil published this revision for review.Fri, Dec 6, 2:20 AM
kamil edited the summary of this revision. (Show Details)
kamil edited the test plan for this revision. (Show Details)
kamil added inline comments.
native/account/restore.js
120–123 ↗(On Diff #46228)

not sure, but maybe object here is better

This revision is now accepted and ready to land.Wed, Dec 11, 2:45 AM
This revision was automatically updated to reflect the committed changes.