Page MenuHomePhabricator
Differential D14112

[native] Move render function from Tooltip to functional component
ClosedPublic
Actions

Authored by angelika on Wed, Dec 11, 7:59 AM.
Tags
None
Referenced Files
F3509960: D14112.id46330.diff
Sat, Dec 21, 9:46 AM
F3509500: D14112.diff
Sat, Dec 21, 5:38 AM
F3507093: D14112.id46472.diff
Fri, Dec 20, 7:18 PM
F3506251: D14112.id46331.diff
Fri, Dec 20, 3:53 PM
F3506144: D14112.id46508.diff
Fri, Dec 20, 3:42 PM
F3504844: D14112.id46410.diff
Fri, Dec 20, 10:47 AM
Unknown Object (File)
Fri, Dec 20, 5:02 AM
Unknown Object (File)
Thu, Dec 19, 11:26 PM
View All 13 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMM0f683239b037: [native] Move render function from Tooltip to functional component
Summary

Move render() function to the functional compoent as a part of Tooltip migration to functional component. This finishes the migration of the Tooltip component to functional component.

Depends on D14111

Test Plan

Open up some tooltips and make sure they look correct.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

angelika created this revision.Wed, Dec 11, 7:59 AM
angelika held this revision as a draft.
angelika added a child revision: D14113: [native] Enable Flow types in Reanimated worklets.Wed, Dec 11, 8:14 AM
Harbormaster completed remote builds in B33012: Diff 46330.Wed, Dec 11, 9:29 AM
angelika published this revision for review.Wed, Dec 11, 4:55 PM
ashoat accepted this revision.Wed, Dec 11, 5:57 PM
ashoat added inline comments.
native/tooltip/tooltip.react.js
150

Nit: can we rename this to just Tooltip now?

This revision is now accepted and ready to land.Wed, Dec 11, 5:57 PM
ashoat added inline comments.Wed, Dec 11, 8:05 PM
native/tooltip/tooltip.react.js
128

This can be renamed now

angelika updated this revision to Diff 46409.Fri, Dec 13, 5:33 AM

Rebase and address feedback

angelika marked 2 inline comments as done.Fri, Dec 13, 6:17 AM
Harbormaster completed remote builds in B33087: Diff 46409.Fri, Dec 13, 7:07 AM
angelika updated this revision to Diff 46472.Mon, Dec 16, 6:21 AM

Rebase

Harbormaster completed remote builds in B33131: Diff 46472.Mon, Dec 16, 8:01 AM
Closed by commit rCOMM0f683239b037: [native] Move render function from Tooltip to functional component (authored by angelika). · Explain WhyMon, Dec 16, 1:34 PM
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMM0f683239b037: [native] Move render function from Tooltip to functional component.

Revision Contents
Changeset List

PathSize
native/
tooltip/
272 lines

Diff 46330

View Options

native/tooltip/tooltip.react.js

Loading...