Page MenuHomePhabricator
Differential D14132

[native] Move onPress and onLayout methods in MultimediaMessageMultimedia to functional component
ClosedPublic
Actions

Authored by angelika on Wed, Dec 11, 12:14 PM.
Tags
None
Referenced Files
F3493999: D14132.id46525.diff
Thu, Dec 19, 4:03 AM
F3493881: D14132.id46426.diff
Thu, Dec 19, 4:00 AM
F3493726: D14132.id46489.diff
Thu, Dec 19, 3:56 AM
F3492626: D14132.diff
Thu, Dec 19, 12:52 AM
F3490585: D14132.diff
Wed, Dec 18, 4:48 PM
Unknown Object (File)
Tue, Dec 17, 3:57 PM
Unknown Object (File)
Fri, Dec 13, 11:17 PM
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMMe8c3300a219b: [native] Move onPress and onLayout methods in MultimediaMessageMultimedia to…
Summary

Move onPress and onLayout methods to functional component as a part of MultimediaMessageMultimedia migration to a functional component. Empty onLayout looks weird but in the history I can see it was introduced to fix some Android measure bug and I believe it so I'm leaving it as it was.

Depends on D14131

Test Plan

Open up a multimedia message and see if it behaves correctly.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

angelika created this revision.Wed, Dec 11, 12:14 PM
angelika held this revision as a draft.
angelika added a child revision: D14133: [native] Migrate opacity in MultimediaMessageMultimedia to Reanimated v2 API in functional component.Wed, Dec 11, 12:26 PM
Harbormaster completed remote builds in B33033: Diff 46351.Wed, Dec 11, 12:57 PM
angelika published this revision for review.Wed, Dec 11, 5:30 PM
ashoat accepted this revision.Wed, Dec 11, 8:03 PM
This revision is now accepted and ready to land.Wed, Dec 11, 8:03 PM
angelika updated this revision to Diff 46426.Fri, Dec 13, 5:42 AM

Rebase and address feedback

Harbormaster completed remote builds in B33104: Diff 46426.Fri, Dec 13, 9:29 AM
angelika updated this revision to Diff 46489.Mon, Dec 16, 6:25 AM

Rebase

Harbormaster completed remote builds in B33148: Diff 46489.Mon, Dec 16, 10:26 AM
Closed by commit rCOMMe8c3300a219b: [native] Move onPress and onLayout methods in MultimediaMessageMultimedia to… (authored by angelika). · Explain WhyMon, Dec 16, 1:35 PM
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMMe8c3300a219b: [native] Move onPress and onLayout methods in MultimediaMessageMultimedia to….

Revision Contents
Changeset List

PathSize
native/
chat/
105 lines

Diff 46351

View Options

native/chat/multimedia-message-multimedia.react.js

Loading...