Page MenuHomePhabricator
Differential D14153

[native] handle waiting for secondary device response
ClosedPublic
Actions

Authored by kamil on Thu, Dec 12, 11:49 AM.
Tags
None
Referenced Files
F3513986: D14153.id46553.diff
Sun, Dec 22, 2:59 AM
Unknown Object (File)
Sat, Dec 21, 12:35 AM
Unknown Object (File)
Thu, Dec 19, 9:56 PM
Unknown Object (File)
Wed, Dec 18, 9:43 AM
Unknown Object (File)
Mon, Dec 16, 11:30 PM
Subscribers
None

Details

Reviewers
tomek
ashoat
Commits
rCOMM09fe192640f4: [native] handle waiting for secondary device response
Summary

ENG-9959.

  1. On success navigate to proper screen.
  2. Implement timeout from ENG-8226.

Depends on D14152

Test Plan
  1. Test adding device.
  2. Comment code on the secondary device to send confirmation, and test both removing and ignoring.
  3. Test other errors during flow like Identity call failure (link).

Diff Detail

Repository
rCOMM Comm
Branch
qr-work
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Thu, Dec 12, 11:49 AM
kamil held this revision as a draft.
kamil edited the test plan for this revision. (Show Details)Thu, Dec 12, 11:51 AM
Harbormaster completed remote builds in B33069: Diff 46390.Thu, Dec 12, 12:13 PM
kamil published this revision for review.Thu, Dec 12, 12:20 PM
ashoat resigned from this revision.Thu, Dec 12, 12:27 PM

Will defer to @tomek on this one – I think it's probably a better bet for him to gain the context on QRAuthContextProvider than for me

tomek accepted this revision.Fri, Dec 13, 6:32 AM

It might be a good idea to have an effect that clears the timeout on unmount.

This revision is now accepted and ready to land.Fri, Dec 13, 6:32 AM
kamil added a child revision: D14159: [native] replace back button with close button on the scanning QR code screen.Mon, Dec 16, 3:27 AM
kamil updated this revision to Diff 46541.Tue, Dec 17, 4:58 AM

clear timeout

Harbormaster completed remote builds in B33162: Diff 46541.Tue, Dec 17, 5:20 AM
Closed by commit rCOMM09fe192640f4: [native] handle waiting for secondary device response (authored by kamil). · Explain WhyTue, Dec 17, 7:06 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM09fe192640f4: [native] handle waiting for secondary device response.

Revision Contents
Changeset List

PathSize
native/
account/
qr-auth/
23 lines

Diff 46390

View Options

native/account/qr-auth/qr-auth-context-provider.js

Loading...