[lib] Deduplicate in getCandidateSidebarItemsForThreadList
ClosedPublic
Actions

Authored by ashoat on Fri, Dec 13, 2:58 PM.

Tags

None

Referenced Files

	F3513794: D14158.diff
	Sun, Dec 22, 2:06 AM

	F3510960: D14158.id46457.diff
	Sat, Dec 21, 12:21 PM

	Unknown Object (File)
	Fri, Dec 20, 11:21 PM

	Unknown Object (File)
	Fri, Dec 20, 8:38 PM

	Unknown Object (File)
	Fri, Dec 20, 7:56 PM

	Unknown Object (File)
	Fri, Dec 20, 2:18 PM

	Unknown Object (File)
	Wed, Dec 18, 9:31 PM

	Unknown Object (File)
	Fri, Dec 13, 9:54 PM

View All 11 Files

Subscribers

tomek

Details

Reviewers

varun
will

Commits

rCOMMe5327d59bf9f: [lib] Deduplicate in getCandidateSidebarItemsForThreadList

Summary

I made a mistake in D14154: I forgot to deduplicate the "general" and unread results.

Depends on D14157

Test Plan

Confirm I no longer see duplicated candidate sidebar items

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Fri, Dec 13, 2:58 PM

Herald added a subscriber: tomek. · View Herald TranscriptFri, Dec 13, 2:58 PM

I'll confirm relevant CI passes before landing

Harbormaster completed remote builds in B33115: Diff 46453.Fri, Dec 13, 3:15 PM

varun accepted this revision.Fri, Dec 13, 4:05 PM

This revision is now accepted and ready to land.Fri, Dec 13, 4:05 PM

Closed by commit rCOMMe5327d59bf9f: [lib] Deduplicate in getCandidateSidebarItemsForThreadList (authored by ashoat). · Explain WhyFri, Dec 13, 4:37 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMe5327d59bf9f: [lib] Deduplicate in getCandidateSidebarItemsForThreadList.

Revision Contents
Changeset List

Path

Size

lib/

shared/

sidebar-item-utils.js

14 lines

Diff 46453

View Options

lib/shared/sidebar-item-utils.js

[lib] Deduplicate in getCandidateSidebarItemsForThreadListClosedPublicActions