Paths

Table of Contentst

[lib] Consider parent timestamp in lastUpdatedTimeIncludingSidebars
ClosedPublic
Actions

Authored by ashoat on Fri, Dec 13, 2:57 PM.

Tags

None

Referenced Files

	F3515248: D14157.id46455.diff
	Sun, Dec 22, 8:13 AM

	F3514173: D14157.diff
	Sun, Dec 22, 3:44 AM

	F3509862: D14157.id46453.diff
	Sat, Dec 21, 8:58 AM

	Unknown Object (File)
	Fri, Dec 20, 4:29 PM

	Unknown Object (File)
	Fri, Dec 20, 11:44 AM

	Unknown Object (File)
	Thu, Dec 19, 7:40 PM

	Unknown Object (File)
	Thu, Dec 19, 5:18 PM

	Unknown Object (File)
	Tue, Dec 17, 4:57 PM

View All 12 Files

Subscribers

tomek

Details

Reviewers

varun
will

Commits

rCOMM8266d4d872f1: [lib] Consider parent timestamp in lastUpdatedTimeIncludingSidebars

Summary

I made a mistake in D14154: I forgot that we should always consider the parent thread's timestamp in lastUpdatedTimeIncludingSidebars.

Depends on D14156

Test Plan

Confirm that we no longer see a massive performance regression

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Fri, Dec 13, 2:57 PM

Herald added a subscriber: tomek. · View Herald TranscriptFri, Dec 13, 2:57 PM

I'll confirm relevant CI passes before landing

ashoat added a child revision: D14158: [lib] Deduplicate in getCandidateSidebarItemsForThreadList.Fri, Dec 13, 2:58 PM

Harbormaster completed remote builds in B33114: Diff 46452.Fri, Dec 13, 3:15 PM

varun accepted this revision.Fri, Dec 13, 4:05 PM

This revision is now accepted and ready to land.Fri, Dec 13, 4:05 PM

Closed by commit rCOMM8266d4d872f1: [lib] Consider parent timestamp in lastUpdatedTimeIncludingSidebars (authored by ashoat). · Explain WhyFri, Dec 13, 4:37 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM8266d4d872f1: [lib] Consider parent timestamp in lastUpdatedTimeIncludingSidebars.

Revision Contents
Changeset List

Path

Size

lib/

selectors/

chat-selectors.js

15 lines

Diff 46455

View Options

lib/selectors/chat-selectors.js

[lib] Consider parent timestamp in lastUpdatedTimeIncludingSidebarsClosedPublicActions