[native] Migrate RobotextMessageTooltipButton component to Reanimated V2 API
ClosedPublic
Actions

Authored by angelika on Wed, Dec 11, 10:48 AM.

Details

Reviewers

ashoat
tomek

Commits

rCOMM7e1b8cd9f234: [native] Migrate RobotextMessageTooltipButton component to Reanimated V2 API

Summary

A straightforward migration: use progressV2 shared value and use useAnimatedStyle instead of useMemo

Depends on D14125

Test Plan

Open up a tooltip on a robotext message and verify it's animated correctly.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Wed, Dec 11, 10:48 AM

angelika held this revision as a draft.

angelika added a child revision: D14127: [native] Remove progress prop from tooltip buttons components.Wed, Dec 11, 10:51 AM

Harbormaster completed remote builds in B33027: Diff 46345.Wed, Dec 11, 2:31 PM

angelika published this revision for review.Wed, Dec 11, 5:28 PM

ashoat accepted this revision.Wed, Dec 11, 7:55 PM

This revision is now accepted and ready to land.Wed, Dec 11, 7:55 PM

Rebase and address feedback

Harbormaster completed remote builds in B33098: Diff 46420.Fri, Dec 13, 8:39 AM

Rebase

Harbormaster completed remote builds in B33142: Diff 46483.Mon, Dec 16, 9:32 AM

Closed by commit rCOMM7e1b8cd9f234: [native] Migrate RobotextMessageTooltipButton component to Reanimated V2 API (authored by angelika). · Explain WhyMon, Dec 16, 1:34 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM7e1b8cd9f234: [native] Migrate RobotextMessageTooltipButton component to Reanimated V2 API.

Revision Contents
Changeset List

Path

Size

native/

chat/

robotext-message-tooltip-button.react.js

25 lines

Diff 46483

View Options

native/chat/robotext-message-tooltip-button.react.js

[native] Migrate RobotextMessageTooltipButton component to Reanimated V2 APIClosedPublicActions