[native] Move tooltip location getter in Tooltip to functional component
ClosedPublic
Actions

Authored by angelika on Wed, Dec 11, 7:40 AM.

Details

Reviewers

ashoat
tomek

Commits

rCOMM2e8a7f12da7c: [native] Move tooltip location getter in Tooltip to functional component

Summary

Simply move get tooltipLocation function to functional component as a part of Tooltip migration to functional component.

Depends on D14106

Test Plan

Open some tooltips and verify they're positioned correctly.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

angelika created this revision.Wed, Dec 11, 7:40 AM

angelika held this revision as a draft.

angelika added a child revision: D14108: [native] Move Reanimated nodes in Tooltip to functional component.Wed, Dec 11, 7:42 AM

Harbormaster completed remote builds in B33007: Diff 46325.Wed, Dec 11, 1:57 PM

angelika published this revision for review.Wed, Dec 11, 4:54 PM

Similar feedback to prior diff: I think these getters can be replaced with the value itself. Feel free to do this all in one final diff in the stack if that's easier

This revision is now accepted and ready to land.Wed, Dec 11, 5:47 PM

Rebase and address feedback

Harbormaster completed remote builds in B33082: Diff 46404.Fri, Dec 13, 6:24 AM

Rebase

Harbormaster completed remote builds in B33126: Diff 46467.Mon, Dec 16, 7:19 AM

Closed by commit rCOMM2e8a7f12da7c: [native] Move tooltip location getter in Tooltip to functional component (authored by angelika). · Explain WhyMon, Dec 16, 1:34 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM2e8a7f12da7c: [native] Move tooltip location getter in Tooltip to functional component.

Revision Contents
Changeset List

Path

Size

native/

tooltip/

tooltip.react.js

73 lines

Diff 46503

View Options

native/tooltip/tooltip.react.js

[native] Move tooltip location getter in Tooltip to functional componentClosedPublicActions