Page MenuHomePhabricator

[native] implement screen when secondary device is not responding
ClosedPublic

Authored by kamil on Thu, Dec 12, 11:34 AM.
Tags
None
Referenced Files
F3523780: D14152.id46541.diff
Mon, Dec 23, 10:14 AM
F3522200: D14152.id46540.diff
Mon, Dec 23, 6:03 AM
F3522178: D14152.id46552.diff
Mon, Dec 23, 6:00 AM
F3521038: D14152.id46387.diff
Mon, Dec 23, 2:07 AM
Unknown Object (File)
Sun, Dec 22, 8:10 AM
Unknown Object (File)
Sat, Dec 21, 9:24 PM
Unknown Object (File)
Sat, Dec 21, 7:47 PM
Unknown Object (File)
Sat, Dec 21, 2:36 PM
Subscribers
None

Details

Summary

ENG-9959.

Copy was discussed in ENG-8226#comment-dea392ea.

I am not sure how to solve this in terms of UX, the time when removing the device is pending:

  1. Like this, there might be a lag before navigating to Linked devices.
  2. Not await promise, but in this case user might see the device on the list, and will disappear after this promise is finished.
  3. Somehow show progress, but don't know how to handle the Ignore button then.

Also, swallowing errors here and just navigating to the Linked devices screen, we could show an Alert but wondering if this is worth it.

In ENG-9968 there is an example of how this looks like.

IMG_4790 (1).PNG (1×828 px, 57 KB)

Depends on D14151

Test Plan

Navigate to this screen

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Thu, Dec 12, 11:58 AM

Rahul has a graphic almost ready for this! We can either amend it here, or handle it later if it takes a bit before he can deliver the final version.

native/account/qr-auth/secondary-device-not-responding.react.js
57 ↗(On Diff #46387)

Nit

72 ↗(On Diff #46387)

Let's add a period at the end here

This revision is now accepted and ready to land.Thu, Dec 12, 12:24 PM