[native] Migrate componentDidUpdate in CameraModal to functional component
ClosedPublic
Actions

Authored by angelika on Jan 20 2025, 1:12 PM.

Details

Reviewers

tomek

Commits

rCOMMd331d2f06588: [native] Migrate componentDidUpdate in CameraModal to functional component

Summary

https://linear.app/comm/issue/ENG-8152/convert-cameramodal-to-reanimated-2-syntax

Migrate componentDidUpdate to useEffects in funcitonal component.

Depends on D14237

Test Plan

Verify focus, loading, taking photos and switching cameras works.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Jan 20 2025, 1:12 PM

angelika held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJan 20 2025, 1:12 PM

angelika added a child revision: D14239: [native] Migrate containerStyle in CameraModal to functional component.Jan 20 2025, 1:13 PM

angelika published this revision for review.Jan 20 2025, 1:27 PM

Harbormaster completed remote builds in B33282: Diff 46735.Jan 20 2025, 2:45 PM

tomek accepted this revision.Jan 21 2025, 10:11 AM

tomek added inline comments.

native/media/camera-modal.react.js
1025–1028 ↗	(On Diff #46735)	Should we call this effect every time `cancelFocusAnimation` changes?

This revision is now accepted and ready to land.Jan 21 2025, 10:11 AM

Rebase & review changes

angelika marked an inline comment as done.Jan 22 2025, 12:57 AM

Harbormaster completed remote builds in B33311: Diff 46768.Jan 22 2025, 3:10 AM

Closed by commit rCOMMd331d2f06588: [native] Migrate componentDidUpdate in CameraModal to functional component. · Explain WhyJan 22 2025, 5:39 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMMd331d2f06588: [native] Migrate componentDidUpdate in CameraModal to functional component.

Revision Contents
Changeset List

Path

Size

native/

media/

camera-modal.react.js

78 lines

Diff 46768

View Options

native/media/camera-modal.react.js

[native] Migrate componentDidUpdate in CameraModal to functional componentClosedPublicActions