Differential D14225

[native] Migrate autoFocusPointOfInterest in CameraModal to funcitonal component
ClosedPublic
Actions

Authored by angelika on Jan 20 2025, 12:16 PM.

Details

Reviewers

tomek

Commits

rCOMM61a8673caeeb: [native] Migrate autoFocusPointOfInterest in CameraModal to funcitonal component

Summary

https://linear.app/comm/issue/ENG-8152/convert-cameramodal-to-reanimated-2-syntax

Migrate autoFocusPointOfInterest state to functional component

Depends on D14224

Test Plan

Test camera focus

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

angelika created this revision.Jan 20 2025, 12:16 PM

angelika held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJan 20 2025, 12:16 PM

angelika added a child revision: D14226: [native] Migrate zoom state in CameraModal to funcitonal component.Jan 20 2025, 12:17 PM

Harbormaster completed remote builds in B33269: Diff 46722.Jan 20 2025, 12:53 PM

angelika published this revision for review.Jan 20 2025, 1:25 PM

tomek accepted this revision.Jan 20 2025, 2:46 PM

tomek added inline comments.

native/media/camera-modal.react.js
1187–1189 ↗	(On Diff #46722)	How about creating a separate type for it? We're repeating it three times.

This revision is now accepted and ready to land.Jan 20 2025, 2:46 PM

Rebase & review changes

angelika marked an inline comment as done.Jan 22 2025, 12:46 AM

Harbormaster completed remote builds in B33298: Diff 46755.Jan 22 2025, 1:18 AM

Closed by commit rCOMM61a8673caeeb: [native] Migrate autoFocusPointOfInterest in CameraModal to funcitonal component. · Explain WhyJan 22 2025, 5:39 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM61a8673caeeb: [native] Migrate autoFocusPointOfInterest in CameraModal to funcitonal component.

Revision Contents
Changeset List

Path

Size

native/

media/

camera-modal.react.js

85 lines

Diff 46788

View Options

native/media/camera-modal.react.js

[native] Migrate autoFocusPointOfInterest in CameraModal to funcitonal componentClosedPublicActions