Page MenuHomePhabricator
Differential D14450

[web] Add SQLite query executor tests
ClosedPublic
Actions

Authored by tomek on Mar 17 2025, 6:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 24, 10:51 AM
Unknown Object (File)
Sun, Apr 20, 7:30 AM
Unknown Object (File)
Sat, Apr 19, 3:38 PM
Unknown Object (File)
Sat, Apr 19, 2:54 PM
Unknown Object (File)
Sat, Apr 19, 12:59 AM
Unknown Object (File)
Fri, Apr 18, 3:02 PM
Unknown Object (File)
Wed, Apr 9, 1:20 PM
Unknown Object (File)
Wed, Apr 9, 12:39 PM
View All 33 Files
Subscribers
ashoat

Details

Reviewers
kamil
bartek
Commits
rCOMMbe6f046a270a: [web] Add SQLite query executor tests
Summary

Add some tests to make sure the executor works.

https://linear.app/comm/issue/ENG-10334/update-jsi-and-web-worker-code-to-support-new-db-operations

Depends on D14449

Test Plan

Tests

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Mar 17 2025, 6:55 AM
Herald added a subscriber: ashoat. · View Herald TranscriptMar 17 2025, 6:55 AM
tomek added a child revision: D14451: [web] Add support for DM operations to the shared worker.Mar 17 2025, 6:57 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 17 2025, 7:11 AM
Harbormaster failed remote builds in B33726: Diff 47415!
tomek updated this revision to Diff 47428.Mar 17 2025, 7:28 AM

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 17 2025, 8:18 AM
Harbormaster failed remote builds in B33738: Diff 47428!
Harbormaster completed remote builds in B33738: Diff 47428.Mar 18 2025, 3:56 AM
tomek requested review of this revision.Mar 18 2025, 3:56 AM
kamil accepted this revision.Mar 18 2025, 7:42 AM
This revision is now accepted and ready to land.Mar 18 2025, 7:42 AM
Closed by commit rCOMMbe6f046a270a: [web] Add SQLite query executor tests (authored by tomek). · Explain WhyMar 19 2025, 9:57 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMbe6f046a270a: [web] Add SQLite query executor tests.

Revision Contents
Changeset List

PathSize
lib/
ops/
14 lines
web/
shared-worker/
queries/
106 lines

Diff 47466

View Options

lib/ops/dm-operations-store-ops.js

Show First 20 Lines • Show All 46 Lines • ▼ Show 20 Linesbutton.menuAction {
font-size: inherit; font-size: inherit;
} }
button.menuAction:hover { button.menuAction:hover {
color: var(--menu-color-hover); color: var(--menu-color-hover);
} }
div.menuActionIcon { div.menuActionIcon {
font-size: 1.125em;
display: flex; display: flex;
justify-content: center; justify-content: center;
margin-right: 8px; margin-right: 8px;
height: 24px;
width: 24px;
}
div.menuActionListMemberActions div.menuActionIcon {
height: 18px;
width: 18px;
} }
button.menuActionDangerous { button.menuActionDangerous {
color: var(--menu-color-dangerous); color: var(--menu-color-dangerous);
} }
button.menuActionDangerous:hover { button.menuActionDangerous:hover {
color: var(--menu-color-dangerous-hover); color: var(--menu-color-dangerous-hover);
} }
hr.separator { hr.separator {
height: 1px; height: 1px;
background: var(--menu-separator-color); background: var(--menu-separator-color);
margin: 10px 16px; margin: 10px 16px;
max-width: 130px; max-width: 130px;
border: none; border: none;
} }
View Options

web/shared-worker/queries/dm-operations-queries.test.js

Show First 20 Lines • Show All 46 Lines • ▼ Show 20 Linesbutton.menuAction {
font-size: inherit; font-size: inherit;
} }
button.menuAction:hover { button.menuAction:hover {
color: var(--menu-color-hover); color: var(--menu-color-hover);
} }
div.menuActionIcon { div.menuActionIcon {
font-size: 1.125em;
display: flex; display: flex;
justify-content: center; justify-content: center;
margin-right: 8px; margin-right: 8px;
height: 24px;
width: 24px;
}
div.menuActionListMemberActions div.menuActionIcon {
height: 18px;
width: 18px;
} }
button.menuActionDangerous { button.menuActionDangerous {
color: var(--menu-color-dangerous); color: var(--menu-color-dangerous);
} }
button.menuActionDangerous:hover { button.menuActionDangerous:hover {
color: var(--menu-color-dangerous-hover); color: var(--menu-color-dangerous-hover);
} }
hr.separator { hr.separator {
height: 1px; height: 1px;
background: var(--menu-separator-color); background: var(--menu-separator-color);
margin: 10px 16px; margin: 10px 16px;
max-width: 130px; max-width: 130px;
border: none; border: none;
} }