Paths

Table of Contentst

Differential D15269

[tunnelbroker] Allow calling Identity from a token connection
ClosedPublic
Actions

Authored by tomek on Aug 29 2025, 1:08 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

bartek
kamil

Commits

rCOMMa5923001c321: [tunnelbroker] Allow calling Identity from a token connection

Summary

We need to call Identity in order to get all the device IDs of the recipient

Depends on D15272

Test Plan

Tested later in the stack

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Aug 29 2025, 1:08 PM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 29 2025, 1:08 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 29 2025, 1:10 PM

Harbormaster failed remote builds in B35586: Diff 50090!

tomek added a child revision: D15270: [tunnelbroker] Broadcast Farcaster messages.Aug 29 2025, 1:21 PM

tomek added a child revision: D15271: [tunnelbroker] Parse Farcaster messages.

tomek removed a child revision: D15270: [tunnelbroker] Broadcast Farcaster messages.Aug 29 2025, 1:26 PM

tomek requested review of this revision.Aug 29 2025, 1:30 PM

tomek edited parent revisions, added: D15272: [lib] Refresh messages after receiving Tunnelbroker message; removed: D15264: [lib] Fetch the most recent messages when opening a thread.Aug 29 2025, 1:34 PM

tomek edited the summary of this revision. (Show Details)

After looking at this now, I would probably pass AuthService to TokenDistributor, not ChainedInterceptedServicesAuthClient, and call get_services_auth_client on request to match how it implemented, e.g,. for find_keyserver_device_for_user on backup, but this is probably fine as it is now

This revision is now accepted and ready to land.Aug 29 2025, 2:52 PM

In D15269#420672, @kamil wrote:

After looking at this now, I would probably pass AuthService to TokenDistributor, not ChainedInterceptedServicesAuthClient, and call get_services_auth_client on request to match how it implemented, e.g,. for find_keyserver_device_for_user on backup, but this is probably fine as it is now

Discussed offline - it seems like there aren't any strong arguments for any approach, so we're keeping this for now.

The taken approach doesn't matter much. If needed, it's easy to refactor to the other in the future.

Fix lint

Harbormaster failed remote builds in B35605: Diff 50120!Sep 1 2025, 4:24 PM

This revision was landed with ongoing or failed builds.Sep 1 2025, 4:44 PM

Closed by commit rCOMMa5923001c321: [tunnelbroker] Allow calling Identity from a token connection. · Explain Why

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMa5923001c321: [tunnelbroker] Allow calling Identity from a token connection.

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

26 lines

token_distributor/

5 lines

token_connection.rs

4 lines

shared/

grpc_clients/

src/

identity/

authenticated.rs

1 line

2 lines

Diff 50120

services/tunnelbroker/src/main.rs

Loading...

services/tunnelbroker/src/token_distributor/mod.rs

Loading...

services/tunnelbroker/src/token_distributor/token_connection.rs

Loading...

shared/grpc_clients/src/identity/authenticated.rs

Loading...

shared/grpc_clients/src/identity/shared.rs

Loading...