[lib] Simplify filterChatThreadList
ClosedPublic
Actions

Authored by ashoat on Feb 8 2022, 7:42 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 10, 11:57 PM

	Unknown Object (File)
	Sun, Nov 10, 11:57 PM

	Unknown Object (File)
	Sun, Nov 10, 11:57 PM

	Unknown Object (File)
	Sun, Nov 10, 11:11 PM

	Unknown Object (File)
	Tue, Nov 5, 12:50 AM

	Unknown Object (File)
	Fri, Oct 25, 8:38 AM

	Unknown Object (File)
	Fri, Oct 25, 8:38 AM

	Unknown Object (File)
	Fri, Oct 25, 8:38 AM

Subscribers

Details

Reviewers

• jacek
tomek

Commits

rCOMM03db030f6828: [lib] Simplify filterChatThreadList

Summary

It's good this function got factored out, because it turns out the logic can be significantly simplified now.

Depends on D2885

Test Plan

Flow, careful code inspection

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D2885

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Feb 8 2022, 7:42 PM

Herald added subscribers: • karol, atul, • adrian. · View Herald TranscriptFeb 8 2022, 7:42 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 8 2022, 7:44 PM

Harbormaster failed remote builds in B6663: Diff 9431!

Build failure is unrelated (backup service)

tomek accepted this revision.Feb 9 2022, 3:34 AM

This revision is now accepted and ready to land.Feb 9 2022, 3:34 AM

Herald added a subscriber: • benschac. · View Herald TranscriptFeb 9 2022, 3:34 AM

• jacek accepted this revision.Feb 11 2022, 2:39 AM

Rebase

Harbormaster completed remote builds in B6847: Diff 9690.Feb 15 2022, 11:03 AM

Closed by commit rCOMM03db030f6828: [lib] Simplify filterChatThreadList (authored by ashoat). · Explain WhyFeb 15 2022, 7:54 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM03db030f6828: [lib] Simplify filterChatThreadList.

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

54 lines

Diff 9431

View Options

lib/shared/thread-utils.js

[lib] Simplify filterChatThreadListClosedPublicActions