Page MenuHomePhabricator
People varun

varun (Varun Dhananjaya)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 30 2021, 11:14 AM (155 w, 1 d)

Recent Activity
View All

Today

varun accepted D13975: [keyserver][native][web] Use FCCache instead of calling fetchFarcasterChannelByID directly.
Wed, Nov 20, 6:59 AM
varun accepted D13974: [lib] Get rid of fetchFollowedFarcasterChannelsWithFilter.
Wed, Nov 20, 6:57 AM
varun accepted D13973: [reports] Upgrade Postmark crate to fix TLS.
Wed, Nov 20, 6:36 AM
varun closed D13854: [keyserver] return threadInfo in fetchAllCommunityInfosWithNames.
Wed, Nov 20, 5:20 AM
varun committed rCOMM183ac09a25b3: [keyserver] return threadInfo in fetchAllCommunityInfosWithNames (authored by varun).
[keyserver] return threadInfo in fetchAllCommunityInfosWithNames
Wed, Nov 20, 5:20 AM
varun closed D13852: [keyserver] new fetchPrivilegedThreadInfos function.
Wed, Nov 20, 5:20 AM
varun committed rCOMM1490b842faf6: [keyserver] new fetchPrivilegedThreadInfos function (authored by varun).
[keyserver] new fetchPrivilegedThreadInfos function
Wed, Nov 20, 5:20 AM

Yesterday

varun added inline comments to D13854: [keyserver] return threadInfo in fetchAllCommunityInfosWithNames.
Tue, Nov 19, 9:27 PM
varun added inline comments to D13852: [keyserver] new fetchPrivilegedThreadInfos function.
Tue, Nov 19, 9:25 PM
varun updated the diff for D13854: [keyserver] return threadInfo in fetchAllCommunityInfosWithNames.

address feedback

Tue, Nov 19, 9:24 PM
varun updated the diff for D13852: [keyserver] new fetchPrivilegedThreadInfos function.

address feedback

Tue, Nov 19, 9:24 PM
varun accepted D13962: [terraform] upgrade backup prod to 0.5.1.
Tue, Nov 19, 6:22 AM

Fri, Nov 15

varun accepted D13945: [terraform] upgrade staging backup to 0.5.1.
Fri, Nov 15, 4:17 PM
varun closed D13949: [keyserver][lib] change thread info validators -> thin raw thread info validators.
Fri, Nov 15, 4:16 PM
varun committed rCOMM5e90e9617847: [keyserver][lib] change thread info validators -> thin raw thread info… (authored by varun).
[keyserver][lib] change thread info validators -> thin raw thread info…
Fri, Nov 15, 4:16 PM
varun published D13949: [keyserver][lib] change thread info validators -> thin raw thread info validators for review.
Fri, Nov 15, 12:52 PM
varun updated the diff for D13852: [keyserver] new fetchPrivilegedThreadInfos function.

make param read only

Fri, Nov 15, 10:19 AM
varun updated the diff for D13852: [keyserver] new fetchPrivilegedThreadInfos function.

new approach without using script viewer

Fri, Nov 15, 10:17 AM
varun abandoned D13853: [keyserver] add know_of permission if viewer.isScriptViewer.

changing approach

Fri, Nov 15, 9:51 AM
varun added a comment to D13851: [keyserver] fetchThreadInfos -> fetchAccessibleThreadInfos.

decided not to rename. will instead call my new function fetchPrivilegedThreadInfos

Fri, Nov 15, 9:50 AM
varun abandoned D13851: [keyserver] fetchThreadInfos -> fetchAccessibleThreadInfos.
Fri, Nov 15, 9:50 AM
varun accepted D13944: [terraform] create backup cloudwatch alarms.

can you please make sure that Linear creates issues when these alarms fire?

Fri, Nov 15, 8:43 AM

Wed, Nov 13

varun closed D13920: [native] remove exitingCallback.
Wed, Nov 13, 11:00 AM
varun committed rCOMM485956d0276d: [native] remove exitingCallback (authored by varun).
[native] remove exitingCallback
Wed, Nov 13, 11:00 AM
varun closed D13917: [native] make the list of NUX tips to be displayed configurable.
Wed, Nov 13, 11:00 AM
varun committed rCOMMe8675e276b22: [native] make the list of NUX tips to be displayed configurable (authored by varun).
[native] make the list of NUX tips to be displayed configurable
Wed, Nov 13, 11:00 AM

Tue, Nov 12

varun requested review of D13920: [native] remove exitingCallback.
Tue, Nov 12, 2:59 PM
varun requested review of D13917: [native] make the list of NUX tips to be displayed configurable.
Tue, Nov 12, 1:47 PM
varun closed D13896: Upgrade to Rust 1.81.
Tue, Nov 12, 1:03 PM
varun closed D13895: [shared] bump opaque-ke to 2.1.0-pre.1.
Tue, Nov 12, 1:03 PM
varun committed rCOMM0350430166db: [shared] bump opaque-ke to 2.1.0-pre.1 (authored by varun).
[shared] bump opaque-ke to 2.1.0-pre.1
Tue, Nov 12, 1:03 PM
varun committed rCOMM6e248249ec7b: Upgrade to Rust 1.81 (authored by varun).
Upgrade to Rust 1.81
Tue, Nov 12, 1:03 PM
varun added inline comments to D13895: [shared] bump opaque-ke to 2.1.0-pre.1.
Tue, Nov 12, 1:02 PM

Fri, Nov 8

varun added inline comments to D13895: [shared] bump opaque-ke to 2.1.0-pre.1.
Fri, Nov 8, 11:57 AM

Thu, Nov 7

varun updated the diff for D13896: Upgrade to Rust 1.81.

minimal Cargo.lock update

Thu, Nov 7, 5:29 PM
varun requested review of D13896: Upgrade to Rust 1.81.
Thu, Nov 7, 4:13 PM
varun updated the diff for D13895: [shared] bump opaque-ke to 2.1.0-pre.1.

add argon2 to root Cargo.toml

Thu, Nov 7, 1:56 PM
varun updated the summary of D13895: [shared] bump opaque-ke to 2.1.0-pre.1.
Thu, Nov 7, 1:41 PM
varun updated the summary of D13895: [shared] bump opaque-ke to 2.1.0-pre.1.
Thu, Nov 7, 1:40 PM
varun removed a reviewer for D13895: [shared] bump opaque-ke to 2.1.0-pre.1: ashoat.

realize there's Rust code so @ashoat isn't a good reviewer

Thu, Nov 7, 1:39 PM
varun updated the test plan for D13895: [shared] bump opaque-ke to 2.1.0-pre.1.
Thu, Nov 7, 1:37 PM
varun requested review of D13895: [shared] bump opaque-ke to 2.1.0-pre.1.
Thu, Nov 7, 1:36 PM
varun accepted D13894: [CommCoreModule] make sure `backupID` is URL-safe string.
Thu, Nov 7, 11:38 AM

Tue, Nov 5

varun accepted D13885: [services] Bump production identity to 0.45.

We normally wait a day before promoting a version from staging to prod

Tue, Nov 5, 12:40 PM
varun accepted D13884: [services] Bump staging identity to 0.45.
Tue, Nov 5, 12:14 PM
varun added a comment to D13883: [services] Remove requirement to specify port for identity service config.

Removed my suggestion, your solution is good

Tue, Nov 5, 11:59 AM
varun accepted D13883: [services] Remove requirement to specify port for identity service config.
Tue, Nov 5, 11:50 AM
varun accepted D13881: [services] Allow browsers to access prod identity from comm.software.

do you need the www URL?

Tue, Nov 5, 9:59 AM
varun accepted D13847: [native] update Secondary Device Auth flow to support SIWE users.
Tue, Nov 5, 8:17 AM
varun accepted D13849: [CommCoreModule][native_rust_library] update downloading User Keys to support user identifier.

LGTM, but setting @bartek as blocking since @kamil has asked for his thoughts above

Tue, Nov 5, 7:35 AM
varun requested changes to D13847: [native] update Secondary Device Auth flow to support SIWE users.

left a question inline

Tue, Nov 5, 7:24 AM
varun accepted D13846: [CommCoreModule][native_rust_library] deprecate SIWE related backup code.
Tue, Nov 5, 7:20 AM
varun accepted D13844: [native] unify username and wallet backup restore.
Tue, Nov 5, 7:16 AM

Mon, Nov 4

varun accepted D13850: [native_rust_library] remove `backupID` from `SIWEBackupData`.
Mon, Nov 4, 7:37 AM
varun accepted D13857: [backup] add code comment to `UserKeys` definition explaining Olm account might be out of date.
Mon, Nov 4, 7:32 AM
varun accepted D13808: [backup-service][backup-client] rename `username` -> `user_identifier`.
Mon, Nov 4, 7:31 AM

Fri, Nov 1

varun requested changes to D13808: [backup-service][backup-client] rename `username` -> `user_identifier`.
Fri, Nov 1, 2:17 PM
varun accepted D13807: [backup-service] use `username` instead of `userID` when downloading backup.
Fri, Nov 1, 2:15 PM
varun accepted D13817: [docker-compose] configure Identity endpoint for backup in commtest.
Fri, Nov 1, 1:41 PM
varun accepted D13806: [backup-service] implement calling `FindUserID` RPC from Backup.
Fri, Nov 1, 1:40 PM
varun added inline comments to D13805: [commtest] use registered `UserIdentity` in backup tests.
Fri, Nov 1, 1:30 PM
varun accepted D13805: [commtest] use registered `UserIdentity` in backup tests.
Fri, Nov 1, 1:28 PM
varun attached a referenced file: F3122660: Simulator Screen Recording - iPhone 16 Pro Max - 2024-11-01 at 13.49.33.mp4.
Fri, Nov 1, 10:53 AM
varun updated the test plan for D13493: [native] scaffolding for CommunityJoinerModal.
Fri, Nov 1, 10:53 AM

Thu, Oct 31

varun updated the diff for D13493: [native] scaffolding for CommunityJoinerModal.

small fixes

Thu, Oct 31, 11:22 PM
varun added inline comments to D13493: [native] scaffolding for CommunityJoinerModal.
Thu, Oct 31, 11:21 PM
varun added a comment to D13493: [native] scaffolding for CommunityJoinerModal.

fixing the avatars here is tracked in https://linear.app/comm/issue/ENG-9834/get-farcaster-thread-avatars-to-render-correctly-in-new-modals

Thu, Oct 31, 11:18 PM
varun attached a referenced file: F3117719: Simulator Screenshot - iPhone 16 Pro Max - 2024-11-01 at 02.15.52.png.
Thu, Oct 31, 11:17 PM
varun added a comment to D13493: [native] scaffolding for CommunityJoinerModal.

Simulator Screenshot - iPhone 16 Pro Max - 2024-11-01 at 02.15.52.png (2×1 px, 306 KB)

Thu, Oct 31, 11:17 PM
varun added a reviewer for D13853: [keyserver] add know_of permission if viewer.isScriptViewer: ashoat.
Thu, Oct 31, 11:12 PM
varun planned changes to D13854: [keyserver] return threadInfo in fetchAllCommunityInfosWithNames.
Thu, Oct 31, 11:12 PM
varun published D13854: [keyserver] return threadInfo in fetchAllCommunityInfosWithNames for review.
Thu, Oct 31, 11:12 PM
varun planned changes to D13853: [keyserver] add know_of permission if viewer.isScriptViewer.
Thu, Oct 31, 11:11 PM
varun requested review of D13853: [keyserver] add know_of permission if viewer.isScriptViewer.
Thu, Oct 31, 11:04 PM
varun requested review of D13852: [keyserver] new fetchPrivilegedThreadInfos function.
Thu, Oct 31, 10:58 PM
varun requested review of D13851: [keyserver] fetchThreadInfos -> fetchAccessibleThreadInfos.
Thu, Oct 31, 10:57 PM
varun updated the diff for D13493: [native] scaffolding for CommunityJoinerModal.

update modal

Thu, Oct 31, 10:50 PM

Wed, Oct 30

varun closed D13818: [terraform] bump prod identity to 0.44.
Wed, Oct 30, 10:32 AM
varun committed rCOMM13c7aded9674: [terraform] bump prod identity to 0.44 (authored by varun).
[terraform] bump prod identity to 0.44
Wed, Oct 30, 10:32 AM
varun accepted D13803: [identity][comm-lib] move `is_valid_ethereum_address` to `comm-lib`.
Wed, Oct 30, 10:18 AM
varun published D13818: [terraform] bump prod identity to 0.44 for review.
Wed, Oct 30, 10:13 AM
varun closed D13810: [lib] SyncCommunityStoreHandler.
Wed, Oct 30, 8:55 AM
varun committed rCOMMded59d66ae76: [lib] SyncCommunityStoreHandler (authored by varun).
[lib] SyncCommunityStoreHandler
Wed, Oct 30, 8:55 AM

Tue, Oct 29

varun updated the diff for D13810: [lib] SyncCommunityStoreHandler.

address feedback

Tue, Oct 29, 9:47 PM
varun updated the diff for D13810: [lib] SyncCommunityStoreHandler.

undo debounce, which didn't seem to work as expected

Tue, Oct 29, 3:18 PM
varun updated the diff for D13810: [lib] SyncCommunityStoreHandler.

debounce fetch community infos

Tue, Oct 29, 3:10 PM
varun accepted D13811: [keyserver] add function to grab comm userID for given fid if on keyserver.
Tue, Oct 29, 3:03 PM
varun added inline comments to D13811: [keyserver] add function to grab comm userID for given fid if on keyserver.
Tue, Oct 29, 2:59 PM
varun requested review of D13810: [lib] SyncCommunityStoreHandler.
Tue, Oct 29, 2:17 PM
varun accepted D13804: [native] Add loading button state to CreateSIWEBackupMessageBase.
Tue, Oct 29, 11:04 AM
varun accepted D13800: [lib][keyserver][native] Stop sending passwords to authoritative keyserver on registration.
Tue, Oct 29, 8:29 AM

Mon, Oct 28

varun accepted D13799: [landing] Remove invalid size prop in TeamProfile.
Mon, Oct 28, 1:17 PM
varun accepted D13796: [landing] Add Farcaster link to team profiles.
Mon, Oct 28, 12:43 PM
varun added a comment to D13795: [landing] Update team page.

I don’t see the screenshot but JSX looks right

Mon, Oct 28, 11:45 AM
varun accepted D13795: [landing] Update team page.
Mon, Oct 28, 11:43 AM
varun closed D13791: [terraform] bump staging identity to 0.44.
Mon, Oct 28, 11:18 AM
varun committed rCOMMd497e16cf572: [terraform] bump staging identity to 0.44 (authored by varun).
[terraform] bump staging identity to 0.44
Mon, Oct 28, 11:18 AM

Fri, Oct 25

varun requested review of D13791: [terraform] bump staging identity to 0.44.
Fri, Oct 25, 1:57 PM
varun closed D13790: [identity] bump native min supported version and add web min supported version.
Fri, Oct 25, 1:35 PM
varun committed rCOMM9644fafebfb1: [identity] bump native min supported version and add web min supported version (authored by varun).
[identity] bump native min supported version and add web min supported version
Fri, Oct 25, 1:35 PM