Page MenuHomePhabricator

varun (Varun Dhananjaya)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 30 2021, 11:14 AM (174 w, 10 h)

Recent Activity

Yesterday

varun planned changes to D14488: [native] enable connect farcaster prompt, display prompt after nux tips have all been dismissed.

need to finish testing this

Mon, Mar 31, 3:42 PM
varun updated the diff for D14488: [native] enable connect farcaster prompt, display prompt after nux tips have all been dismissed.

make cold start count a per-alert type count instead of a global count, migrations, stagger the connect farcaster and community directory prompts

Mon, Mar 31, 3:42 PM

Wed, Mar 26

varun updated the diff for D14488: [native] enable connect farcaster prompt, display prompt after nux tips have all been dismissed.
  1. use coldStartCount to make sure we don't display connect farcaster alert right after NUX
  2. use connectFarcasterAlertInfo in DisplayCommunityDirectoryPromptHandler to make sure we don't display community directory prompt until a day after connect farcaster prompt
Wed, Mar 26, 7:55 PM

Sun, Mar 23

varun published D14488: [native] enable connect farcaster prompt, display prompt after nux tips have all been dismissed for review.
Sun, Mar 23, 9:25 AM
varun added a comment to D14444: [lib] launch connect farcaster prompt.

the hardware back button on android does close the bottom sheet, but doesn't trigger the component's onChange callback

Sun, Mar 23, 8:23 AM
varun updated the diff for D14444: [lib] launch connect farcaster prompt.

address feedback

Sun, Mar 23, 8:18 AM

Sun, Mar 16

varun added inline comments to D14444: [lib] launch connect farcaster prompt.
Sun, Mar 16, 7:32 PM
varun added inline comments to D14444: [lib] launch connect farcaster prompt.
Sun, Mar 16, 7:28 PM
varun added a comment to D14444: [lib] launch connect farcaster prompt.

Feels like there are probably ways to dismiss the modal without setting the fid to null here. Ideally we can catch all methods of closing the modal, but if that's really hard, one alternative would just be to set the fid to null as soon as we show the modal.

Sun, Mar 16, 7:27 PM
varun added inline comments to D14444: [lib] launch connect farcaster prompt.
Sun, Mar 16, 7:22 PM
varun added inline comments to D14444: [lib] launch connect farcaster prompt.
Sun, Mar 16, 6:43 PM
varun updated subscribers of D14444: [lib] launch connect farcaster prompt.
Sun, Mar 16, 6:26 PM
varun added a comment to D14444: [lib] launch connect farcaster prompt.

Does it not occur on every single login because the NUX doesn't display on subsequent logins?

Sun, Mar 16, 6:23 PM
varun added a comment to D14444: [lib] launch connect farcaster prompt.

Alternately, does this occur for every fresh install login?

Sun, Mar 16, 6:09 PM
varun requested review of D14446: [native] flip showCommunityDirectory to true.
Sun, Mar 16, 3:32 PM
varun requested review of D14445: [native] hide community directory prompt on dev.
Sun, Mar 16, 3:22 PM
varun added a comment to D14444: [lib] launch connect farcaster prompt.

Ended up testing the connect farcaster flow and it works. A couple things worth noting:

  1. The connect farcaster bottom sheet appears at the same time as the NUX tips if the user installs the app and logs in. Not sure if this edge case is worth addressing
Sun, Mar 16, 2:54 PM
varun updated the diff for D14444: [lib] launch connect farcaster prompt.

some updates

Sun, Mar 16, 2:47 PM
varun planned changes to D14444: [lib] launch connect farcaster prompt.

need to think about how to sequence things a little more

Sun, Mar 16, 10:40 AM
varun requested review of D14444: [lib] launch connect farcaster prompt.
Sun, Mar 16, 10:24 AM

Sat, Mar 15

varun closed D14443: [native] cache LoadableImage in memory and disk.
Sat, Mar 15, 2:15 PM
varun committed rCOMM0f2665625267: [native] cache LoadableImage in memory and disk (authored by varun).
[native] cache LoadableImage in memory and disk
Sat, Mar 15, 2:15 PM
varun added inline comments to D14443: [native] cache LoadableImage in memory and disk.
Sat, Mar 15, 11:28 AM

Mar 1 2025

varun closed D14421: [native] navigate to nux tip on modal close if user opened CommunityJoinerModal from bottom sheet.
Mar 1 2025, 2:25 PM
varun committed rCOMM9c332325400a: [native] navigate to nux tip on modal close if user opened CommunityJoinerModal… (authored by varun).
[native] navigate to nux tip on modal close if user opened CommunityJoinerModal…
Mar 1 2025, 2:25 PM
varun closed D14420: [native] navigate to CommunityJoinerModal if user accepts prompt.
Mar 1 2025, 2:25 PM
varun closed D14378: [keyserver] boost certain community IDs.
Mar 1 2025, 2:25 PM
varun committed rCOMM83a42c0da9f8: [native] navigate to CommunityJoinerModal if user accepts prompt (authored by varun).
[native] navigate to CommunityJoinerModal if user accepts prompt
Mar 1 2025, 2:25 PM
varun committed rCOMM4fc41a0cf410: [keyserver] boost certain community IDs (authored by varun).
[keyserver] boost certain community IDs
Mar 1 2025, 2:25 PM
varun closed D14205: rename fetchAllCommunityInfosWithNames -> fetchNativeDrawerAndDirectoryInfos.
Mar 1 2025, 2:25 PM
varun closed D14204: [native] fix avatars in directory.
Mar 1 2025, 2:25 PM
varun committed rCOMM2634be67d26f: rename fetchAllCommunityInfosWithNames -> fetchNativeDrawerAndDirectoryInfos (authored by varun).
rename fetchAllCommunityInfosWithNames -> fetchNativeDrawerAndDirectoryInfos
Mar 1 2025, 2:25 PM
varun committed rCOMM3c9b48962905: [native] fix avatars in directory (authored by varun).
[native] fix avatars in directory
Mar 1 2025, 2:25 PM
varun closed D14181: [keyserver] filter out communities that viewer is a member of or that aren't public.
Mar 1 2025, 2:25 PM
varun closed D14054: [native] navigate to community directory nux tip if user declines prompt or closes bottom sheet.
Mar 1 2025, 2:25 PM
varun committed rCOMM7f2d97318b52: [keyserver] filter out communities that viewer is a member of or that aren't… (authored by varun).
[keyserver] filter out communities that viewer is a member of or that aren't…
Mar 1 2025, 2:25 PM
varun committed rCOMM170dee3fa121: [native] navigate to community directory nux tip if user declines prompt or… (authored by varun).
[native] navigate to community directory nux tip if user declines prompt or…
Mar 1 2025, 2:25 PM
varun closed D14053: [native] DisplayCommunityDirectoryPrompt.
Mar 1 2025, 2:25 PM
varun committed rCOMM923ce0279648: [native] DisplayCommunityDirectoryPrompt (authored by varun).
[native] DisplayCommunityDirectoryPrompt
Mar 1 2025, 2:25 PM
varun added a comment to D14378: [keyserver] boost certain community IDs.

Can you share a screenshot of the order we end up seeing? Curious in what order the boosted communities will appear

Mar 1 2025, 2:10 PM
varun added inline comments to D14053: [native] DisplayCommunityDirectoryPrompt.
Mar 1 2025, 1:47 PM
varun closed D14391: [native] ColdStartTracker.
Mar 1 2025, 9:08 AM
varun committed rCOMMebee92ea5903: [native] ColdStartTracker (authored by varun).
[native] ColdStartTracker
Mar 1 2025, 9:08 AM
varun added inline comments to D14391: [native] ColdStartTracker.
Mar 1 2025, 9:04 AM
varun added inline comments to D14421: [native] navigate to nux tip on modal close if user opened CommunityJoinerModal from bottom sheet.
Mar 1 2025, 9:01 AM
varun added inline comments to D14420: [native] navigate to CommunityJoinerModal if user accepts prompt.
Mar 1 2025, 9:00 AM

Feb 28 2025

varun published D14421: [native] navigate to nux tip on modal close if user opened CommunityJoinerModal from bottom sheet for review.

CI has been stuck for a day

Feb 28 2025, 2:48 PM
varun published D14420: [native] navigate to CommunityJoinerModal if user accepts prompt for review.

CI has been stuck for a day

Feb 28 2025, 2:48 PM

Feb 27 2025

varun updated the diff for D14053: [native] DisplayCommunityDirectoryPrompt.

address feedback

Feb 27 2025, 9:36 PM

Feb 19 2025

varun requested review of D14391: [native] ColdStartTracker.
Feb 19 2025, 8:08 PM

Feb 17 2025

varun requested review of D14378: [keyserver] boost certain community IDs.
Feb 17 2025, 4:22 PM

Feb 16 2025

varun added inline comments to D14204: [native] fix avatars in directory.
Feb 16 2025, 4:26 PM
varun updated the diff for D14204: [native] fix avatars in directory.

address feedback

Feb 16 2025, 4:22 PM

Feb 11 2025

varun added inline comments to D14204: [native] fix avatars in directory.
Feb 11 2025, 9:08 PM
varun added inline comments to D14204: [native] fix avatars in directory.
Feb 11 2025, 8:55 PM
varun added a comment to D14053: [native] DisplayCommunityDirectoryPrompt.
Feb 11 2025, 8:15 PM
varun published D14053: [native] DisplayCommunityDirectoryPrompt for review.
Feb 11 2025, 8:15 PM
varun closed D13997: [native] update community drawer button to navigate to community joiner modal.
Feb 11 2025, 7:45 PM
varun committed rCOMM0d9f892d8aeb: [native] update community drawer button to navigate to community joiner modal (authored by varun).
[native] update community drawer button to navigate to community joiner modal
Feb 11 2025, 7:45 PM
varun closed D13996: [native] community joiner modal.
Feb 11 2025, 7:43 PM
varun committed rCOMMe4bd51bfcd4a: [native] community joiner modal (authored by varun).
[native] community joiner modal
Feb 11 2025, 7:43 PM
varun reopened D13997: [native] update community drawer button to navigate to community joiner modal.
Feb 11 2025, 7:28 PM
varun reopened D13996: [native] community joiner modal.

reverted this change. reopening to reintroduce the change

Feb 11 2025, 7:27 PM
varun added a reverting change for D13996: [native] community joiner modal: rCOMM8c2b299d0551: Revert "[native] community joiner modal".
Feb 11 2025, 7:27 PM
varun committed rCOMM8c2b299d0551: Revert "[native] community joiner modal" (authored by varun).
Revert "[native] community joiner modal"
Feb 11 2025, 7:27 PM
varun added a reverting change for rCOMM8d9060f37976: [native] community joiner modal: rCOMM8c2b299d0551: Revert "[native] community joiner modal".
Feb 11 2025, 7:27 PM
varun added a reverting change for rCOMM4c8f460c450b: [native] update community drawer button to navigate to community joiner modal: rCOMM3fe14f5bbe84: Revert "[native] update community drawer button to navigate to community joiner….
Feb 11 2025, 7:27 PM
varun added a reverting change for D13997: [native] update community drawer button to navigate to community joiner modal: rCOMM3fe14f5bbe84: Revert "[native] update community drawer button to navigate to community joiner….
Feb 11 2025, 7:27 PM
varun committed rCOMM3fe14f5bbe84: Revert "[native] update community drawer button to navigate to community joiner… (authored by varun).
Revert "[native] update community drawer button to navigate to community joiner…
Feb 11 2025, 7:27 PM
varun added a comment to D13996: [native] community joiner modal.

Ah I accidentally landed an older version of this diff

Feb 11 2025, 7:25 PM
varun closed D13997: [native] update community drawer button to navigate to community joiner modal.
Feb 11 2025, 6:50 PM
varun committed rCOMM4c8f460c450b: [native] update community drawer button to navigate to community joiner modal (authored by varun).
[native] update community drawer button to navigate to community joiner modal
Feb 11 2025, 6:50 PM
varun closed D13996: [native] community joiner modal.
Feb 11 2025, 6:44 PM
varun committed rCOMM8d9060f37976: [native] community joiner modal (authored by varun).
[native] community joiner modal
Feb 11 2025, 6:44 PM
varun attached a referenced file: F3993142: Simulator Screenshot - iPhone 16 Pro Max - 2025-02-03 at 20.22.52.png.
Feb 11 2025, 6:40 PM

Feb 3 2025

varun abandoned D13508: [lib] introduce JOIN_COMMUNITY alert type.
Feb 3 2025, 6:57 PM
varun abandoned D13509: [native] join community alert handler.
Feb 3 2025, 6:57 PM
varun added inline comments to D13996: [native] community joiner modal.
Feb 3 2025, 6:19 PM
varun updated the diff for D13996: [native] community joiner modal.

address feedback

Feb 3 2025, 6:18 PM
varun added inline comments to D13996: [native] community joiner modal.
Feb 3 2025, 5:12 PM
varun added inline comments to D14204: [native] fix avatars in directory.
Feb 3 2025, 4:59 PM
varun added inline comments to D14205: rename fetchAllCommunityInfosWithNames -> fetchNativeDrawerAndDirectoryInfos.
Feb 3 2025, 4:32 PM

Jan 30 2025

varun added inline comments to D13996: [native] community joiner modal.
Jan 30 2025, 10:55 AM

Jan 29 2025

varun requested review of D14054: [native] navigate to community directory nux tip if user declines prompt or closes bottom sheet.
Jan 29 2025, 6:22 PM
varun attached a referenced file: F3938810: Simulator Screen Recording - iPhone 16 Pro Max - 2025-01-29 at 21.20.50.mp4.
Jan 29 2025, 6:21 PM
varun updated the test plan for D14054: [native] navigate to community directory nux tip if user declines prompt or closes bottom sheet.
Jan 29 2025, 6:21 PM
varun published D14205: rename fetchAllCommunityInfosWithNames -> fetchNativeDrawerAndDirectoryInfos for review.
Jan 29 2025, 5:57 PM
varun added inline comments to D13996: [native] community joiner modal.
Jan 29 2025, 5:45 PM
varun updated the diff for D13996: [native] community joiner modal.

fix light mode

Jan 29 2025, 5:43 PM
varun updated the diff for D13996: [native] community joiner modal.

address most of the diff feedback

Jan 29 2025, 5:38 PM
varun published D14204: [native] fix avatars in directory for review.
Jan 29 2025, 5:35 PM
varun added inline comments to D13996: [native] community joiner modal.
Jan 29 2025, 5:28 PM

Jan 14 2025

varun closed D13995: [native] introduce community list component.
Jan 14 2025, 1:09 PM
varun committed rCOMM3427c719adc5: [native] introduce community list component (authored by varun).
[native] introduce community list component
Jan 14 2025, 1:09 PM
varun added inline comments to D13995: [native] introduce community list component.
Jan 14 2025, 1:08 PM
varun closed D13994: [native] community list item component.
Jan 14 2025, 12:59 PM
varun committed rCOMM3881e5fa01dd: [native] community list item component (authored by varun).
[native] community list item component
Jan 14 2025, 12:59 PM
varun closed D13987: [native] button in community drawer for exploring communities.
Jan 14 2025, 12:55 PM
varun committed rCOMMc014a2f291b8: [native] button in community drawer for exploring communities (authored by varun).
[native] button in community drawer for exploring communities
Jan 14 2025, 12:55 PM
varun added inline comments to D14181: [keyserver] filter out communities that viewer is a member of or that aren't public.
Jan 14 2025, 12:45 PM