Page MenuHomePhabricator

varun (Varun Dhananjaya)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 30 2021, 11:14 AM (159 w, 6 d)

Recent Activity

Today

varun attached a referenced file: F3522827: Simulator Screen Recording - iPhone 16 Pro - 2024-12-23 at 10.28.45.mp4.
Mon, Dec 23, 7:37 AM
varun added a comment to D13994: [native] community list item component.

Mon, Dec 23, 7:37 AM
varun updated the diff for D13994: [native] community list item component.

address feedback

Mon, Dec 23, 7:36 AM

Fri, Dec 13

varun accepted D14157: [lib] Consider parent timestamp in lastUpdatedTimeIncludingSidebars.
Fri, Dec 13, 4:05 PM
varun accepted D14158: [lib] Deduplicate in getCandidateSidebarItemsForThreadList.
Fri, Dec 13, 4:05 PM
varun added inline comments to D13994: [native] community list item component.
Fri, Dec 13, 8:56 AM
varun added a comment to D13994: [native] community list item component.

Latest look at the modal with the redesigned CommunityListItem component

Fri, Dec 13, 8:29 AM
varun updated the diff for D13994: [native] community list item component.

Move joinStatus closer to where it's used

Fri, Dec 13, 8:27 AM
varun updated the diff for D13994: [native] community list item component.

address feedback

Fri, Dec 13, 8:22 AM

Thu, Dec 12

varun added inline comments to D13996: [native] community joiner modal.
Thu, Dec 12, 2:12 PM
varun closed D14145: [keyserver][script] get IDs for community names.
Thu, Dec 12, 12:27 PM
varun committed rCOMM459ec0313932: [keyserver][script] get IDs for community names (authored by varun).
[keyserver][script] get IDs for community names
Thu, Dec 12, 12:27 PM
varun added inline comments to D14145: [keyserver][script] get IDs for community names.
Thu, Dec 12, 12:19 PM
varun updated the diff for D14145: [keyserver][script] get IDs for community names.

address feedback

Thu, Dec 12, 12:19 PM
varun updated the diff for D13997: [native] update community drawer button to navigate to community joiner modal.

fix navigation param

Thu, Dec 12, 11:46 AM
varun planned changes to D13997: [native] update community drawer button to navigate to community joiner modal.
Thu, Dec 12, 11:40 AM
varun updated the diff for D13997: [native] update community drawer button to navigate to community joiner modal.

address feedback

Thu, Dec 12, 11:35 AM
varun added inline comments to D13996: [native] community joiner modal.
Thu, Dec 12, 8:05 AM
varun updated the summary of D14145: [keyserver][script] get IDs for community names.
Thu, Dec 12, 7:56 AM

Wed, Dec 11

varun updated the diff for D13996: [native] community joiner modal.

address feedback

Wed, Dec 11, 10:33 PM
varun requested review of D14145: [keyserver][script] get IDs for community names.
Wed, Dec 11, 9:40 PM
varun added inline comments to D13996: [native] community joiner modal.
Wed, Dec 11, 9:28 PM
varun updated the diff for D13995: [native] introduce community list component.

rewrite as a functional component

Wed, Dec 11, 8:43 PM
varun added a comment to D13994: [native] community list item component.

It looks like you got a lot of this from another file. If any of my feedback here applies to the original file, can you make sure to make the changes there too?

Wed, Dec 11, 11:18 AM
varun added a comment to D13986: [native] bottom sheet for exploring communities.

Nice! Just wondering, how'd you get the SVG fixed up?

Wed, Dec 11, 9:35 AM

Tue, Dec 10

varun updated the diff for D13986: [native] bottom sheet for exploring communities.

remove onLayout callback that I used to calculate component height

Tue, Dec 10, 11:46 PM
varun added a comment to D13986: [native] bottom sheet for exploring communities.

Screenshot of latest version of bottom sheet

Tue, Dec 10, 11:27 PM
varun updated the diff for D13986: [native] bottom sheet for exploring communities.

address feedback

Tue, Dec 10, 11:27 PM

Mon, Dec 2

varun closed D14070: [terraform] identity 0.46 staging deployment.
Mon, Dec 2, 7:17 PM
varun committed rCOMM8a57c1cde452: [terraform] identity 0.46 staging deployment (authored by varun).
[terraform] identity 0.46 staging deployment
Mon, Dec 2, 7:17 PM
varun requested review of D14070: [terraform] identity 0.46 staging deployment.
Mon, Dec 2, 3:49 PM

Wed, Nov 27

varun added inline comments to D14054: [native] navigate to community directory nux tip if user declines prompt or closes bottom sheet.
Wed, Nov 27, 11:10 AM

Tue, Nov 26

varun requested review of D14054: [native] navigate to community directory nux tip if user declines prompt or closes bottom sheet.
Tue, Nov 26, 10:36 PM
varun added inline comments to D13986: [native] bottom sheet for exploring communities.
Tue, Nov 26, 9:55 AM

Mon, Nov 25

varun added inline comments to D13994: [native] community list item component.
Mon, Nov 25, 10:34 PM
varun added inline comments to D13986: [native] bottom sheet for exploring communities.
Mon, Nov 25, 10:30 PM
varun accepted D14042: [keyserver] Introduce metrics for number of message authors.
Mon, Nov 25, 2:05 PM
varun accepted D14041: [keyserver] Add metrics for weekly retention.
Mon, Nov 25, 2:04 PM
varun added inline comments to D14040: [keyserver] Add param to getRetention to customize activity period being checked.
Mon, Nov 25, 2:04 PM
varun accepted D14040: [keyserver] Add param to getRetention to customize activity period being checked.
Mon, Nov 25, 2:02 PM
varun accepted D14043: [keyserver] Introduce metric for weekly active users.
Mon, Nov 25, 1:53 PM

Nov 21 2024

varun requested review of D13997: [native] update community drawer button to navigate to community joiner modal.
Nov 21 2024, 10:51 PM
varun abandoned D13493: [native] scaffolding for CommunityJoinerModal.
Nov 21 2024, 10:14 PM
varun added a comment to D13996: [native] community joiner modal.

btw, this diff replaces D13493, which I plan on abandoning. i think i've applied all the feedback from there, but referencing here just in case

Nov 21 2024, 10:14 PM
varun requested review of D13996: [native] community joiner modal.
Nov 21 2024, 8:18 PM
varun requested review of D13995: [native] introduce community list component.
Nov 21 2024, 2:00 PM
varun added a comment to D13994: [native] community list item component.

the search bar placeholder text is in the following diff, where it is actually "Search communities" (see D13995)

Nov 21 2024, 1:46 PM
varun updated the test plan for D13994: [native] community list item component.
Nov 21 2024, 11:30 AM
varun attached a referenced file: F3335850: RPReplay_Final1732217286.MP4.
Nov 21 2024, 11:30 AM
varun added a comment to D13994: [native] community list item component.
Nov 21 2024, 11:30 AM
varun accepted D13958: [lib] Extract function to download blob.
Nov 21 2024, 11:25 AM
varun accepted D13957: [keyserver] Add function to clear identity metadata.
Nov 21 2024, 11:09 AM
varun requested review of D13994: [native] community list item component.
Nov 21 2024, 10:23 AM
varun added inline comments to D13986: [native] bottom sheet for exploring communities.
Nov 21 2024, 7:31 AM
varun requested review of D13987: [native] button in community drawer for exploring communities.
Nov 21 2024, 12:32 AM
varun requested review of D13986: [native] bottom sheet for exploring communities.
Nov 21 2024, 12:08 AM

Nov 20 2024

varun accepted D13975: [keyserver][native][web] Use FCCache instead of calling fetchFarcasterChannelByID directly.
Nov 20 2024, 6:59 AM
varun accepted D13974: [lib] Get rid of fetchFollowedFarcasterChannelsWithFilter.
Nov 20 2024, 6:57 AM
varun accepted D13973: [reports] Upgrade Postmark crate to fix TLS.
Nov 20 2024, 6:36 AM
varun closed D13854: [keyserver] return threadInfo in fetchAllCommunityInfosWithNames.
Nov 20 2024, 5:20 AM
varun committed rCOMM183ac09a25b3: [keyserver] return threadInfo in fetchAllCommunityInfosWithNames (authored by varun).
[keyserver] return threadInfo in fetchAllCommunityInfosWithNames
Nov 20 2024, 5:20 AM
varun closed D13852: [keyserver] new fetchPrivilegedThreadInfos function.
Nov 20 2024, 5:20 AM
varun committed rCOMM1490b842faf6: [keyserver] new fetchPrivilegedThreadInfos function (authored by varun).
[keyserver] new fetchPrivilegedThreadInfos function
Nov 20 2024, 5:20 AM

Nov 19 2024

varun added inline comments to D13854: [keyserver] return threadInfo in fetchAllCommunityInfosWithNames.
Nov 19 2024, 9:27 PM
varun added inline comments to D13852: [keyserver] new fetchPrivilegedThreadInfos function.
Nov 19 2024, 9:25 PM
varun updated the diff for D13854: [keyserver] return threadInfo in fetchAllCommunityInfosWithNames.

address feedback

Nov 19 2024, 9:24 PM
varun updated the diff for D13852: [keyserver] new fetchPrivilegedThreadInfos function.

address feedback

Nov 19 2024, 9:24 PM
varun accepted D13962: [terraform] upgrade backup prod to 0.5.1.
Nov 19 2024, 6:22 AM

Nov 15 2024

varun accepted D13945: [terraform] upgrade staging backup to 0.5.1.
Nov 15 2024, 4:17 PM
varun closed D13949: [keyserver][lib] change thread info validators -> thin raw thread info validators.
Nov 15 2024, 4:16 PM
varun committed rCOMM5e90e9617847: [keyserver][lib] change thread info validators -> thin raw thread info… (authored by varun).
[keyserver][lib] change thread info validators -> thin raw thread info…
Nov 15 2024, 4:16 PM
varun published D13949: [keyserver][lib] change thread info validators -> thin raw thread info validators for review.
Nov 15 2024, 12:52 PM
varun updated the diff for D13852: [keyserver] new fetchPrivilegedThreadInfos function.

make param read only

Nov 15 2024, 10:19 AM
varun updated the diff for D13852: [keyserver] new fetchPrivilegedThreadInfos function.

new approach without using script viewer

Nov 15 2024, 10:17 AM
varun abandoned D13853: [keyserver] add know_of permission if viewer.isScriptViewer.

changing approach

Nov 15 2024, 9:51 AM
varun added a comment to D13851: [keyserver] fetchThreadInfos -> fetchAccessibleThreadInfos.

decided not to rename. will instead call my new function fetchPrivilegedThreadInfos

Nov 15 2024, 9:50 AM
varun abandoned D13851: [keyserver] fetchThreadInfos -> fetchAccessibleThreadInfos.
Nov 15 2024, 9:50 AM
varun accepted D13944: [terraform] create backup cloudwatch alarms.

can you please make sure that Linear creates issues when these alarms go off?

Nov 15 2024, 8:43 AM

Nov 13 2024

varun closed D13920: [native] remove exitingCallback.
Nov 13 2024, 11:00 AM
varun committed rCOMM485956d0276d: [native] remove exitingCallback (authored by varun).
[native] remove exitingCallback
Nov 13 2024, 11:00 AM
varun closed D13917: [native] make the list of NUX tips to be displayed configurable.
Nov 13 2024, 11:00 AM
varun committed rCOMMe8675e276b22: [native] make the list of NUX tips to be displayed configurable (authored by varun).
[native] make the list of NUX tips to be displayed configurable
Nov 13 2024, 11:00 AM

Nov 12 2024

varun requested review of D13920: [native] remove exitingCallback.
Nov 12 2024, 2:59 PM
varun requested review of D13917: [native] make the list of NUX tips to be displayed configurable.
Nov 12 2024, 1:47 PM
varun closed D13896: Upgrade to Rust 1.81.
Nov 12 2024, 1:03 PM
varun closed D13895: [shared] bump opaque-ke to 2.1.0-pre.1.
Nov 12 2024, 1:03 PM
varun committed rCOMM0350430166db: [shared] bump opaque-ke to 2.1.0-pre.1 (authored by varun).
[shared] bump opaque-ke to 2.1.0-pre.1
Nov 12 2024, 1:03 PM
varun committed rCOMM6e248249ec7b: Upgrade to Rust 1.81 (authored by varun).
Upgrade to Rust 1.81
Nov 12 2024, 1:03 PM
varun added inline comments to D13895: [shared] bump opaque-ke to 2.1.0-pre.1.
Nov 12 2024, 1:02 PM

Nov 8 2024

varun added inline comments to D13895: [shared] bump opaque-ke to 2.1.0-pre.1.
Nov 8 2024, 11:57 AM

Nov 7 2024

varun updated the diff for D13896: Upgrade to Rust 1.81.

minimal Cargo.lock update

Nov 7 2024, 5:29 PM
varun requested review of D13896: Upgrade to Rust 1.81.
Nov 7 2024, 4:13 PM
varun updated the diff for D13895: [shared] bump opaque-ke to 2.1.0-pre.1.

get argon2 0.5 from root Cargo.toml

Nov 7 2024, 1:56 PM
varun updated the summary of D13895: [shared] bump opaque-ke to 2.1.0-pre.1.
Nov 7 2024, 1:41 PM
varun updated the summary of D13895: [shared] bump opaque-ke to 2.1.0-pre.1.
Nov 7 2024, 1:40 PM
varun removed a reviewer for D13895: [shared] bump opaque-ke to 2.1.0-pre.1: ashoat.

realize there's Rust code so @ashoat isn't a good reviewer

Nov 7 2024, 1:39 PM
varun updated the test plan for D13895: [shared] bump opaque-ke to 2.1.0-pre.1.
Nov 7 2024, 1:37 PM
varun requested review of D13895: [shared] bump opaque-ke to 2.1.0-pre.1.
Nov 7 2024, 1:36 PM
varun accepted D13894: [CommCoreModule] make sure `backupID` is URL-safe string.
Nov 7 2024, 11:38 AM

Nov 5 2024

varun accepted D13885: [services] Bump production identity to 0.45.

We normally wait a day before promoting a version from staging to prod

Nov 5 2024, 12:40 PM