[native] Add some memoization to `ImagePasteModal`
ClosedPublic
Actions

Authored by atul on Nov 27 2023, 11:56 AM.

Details

Reviewers

ashoat
ginsu
tomek
rohan

Commits

rCOMMa7185f3028d3: [native] Add some memoization to `ImagePasteModal`

Summary

Noticed a few obvious issues when addressing D10059, figured I'd put up a super quick diff to address.

Test Plan

Should be noop refactor

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D10046

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Nov 27 2023, 11:56 AM

atul published this revision for review.Nov 27 2023, 12:07 PM

Thanks for fixing this up

native/chat/image-paste-modal.react.js
54	This could be extracted outside of the component

This revision is now accepted and ready to land.Nov 27 2023, 12:24 PM

Harbormaster failed remote builds in B24533: Diff 33762!Nov 27 2023, 12:34 PM

amend

Harbormaster completed remote builds in B24537: Diff 33766.Nov 27 2023, 1:33 PM

Closed by commit rCOMMa7185f3028d3: [native] Add some memoization to `ImagePasteModal` (authored by atul). · Explain WhyNov 27 2023, 1:34 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMa7185f3028d3: [native] Add some memoization to `ImagePasteModal`.

Revision Contents
Changeset List

Path

Size

native/

chat/

image-paste-modal.react.js

47 lines

Diff 33762

View Options

native/chat/image-paste-modal.react.js

Show First 20 Lines • Show All 739 Lines • ▼ Show 20 Lines	async () => {
SQL`		SQL`
ALTER TABLE updates		ALTER TABLE updates
MODIFY \`key\` varchar(255) CHARSET latin1 COLLATE latin1_bin		MODIFY \`key\` varchar(255) CHARSET latin1 COLLATE latin1_bin
`,		`,
);		);
},		},
],		],
[59, () => dbQuery(SQL`DROP TABLE one_time_keys`)],		[59, () => dbQuery(SQL`DROP TABLE one_time_keys`)],
		[
		60,
		async () => {
		await dbQuery(
		SQL`
		DELETE
		FROM messages
		WHERE type = 22
		AND JSON_EXTRACT(content, '$.operation') = 'farcaster_mutual'
		`,
		);
		},
		],
]);		]);
const newDatabaseVersion: number = Math.max(...migrations.keys());		const newDatabaseVersion: number = Math.max(...migrations.keys());

async function writeJSONToFile(data: any, filePath: string): Promise<void> {		async function writeJSONToFile(data: any, filePath: string): Promise<void> {
console.warn(`updating ${filePath} to ${JSON.stringify(data)}`);		console.warn(`updating ${filePath} to ${JSON.stringify(data)}`);
const fileHandle = await fs.promises.open(filePath, 'w');		const fileHandle = await fs.promises.open(filePath, 'w');
await fileHandle.writeFile(JSON.stringify(data, null, ' '), 'utf8');		await fileHandle.writeFile(JSON.stringify(data, null, ' '), 'utf8');
await fileHandle.close();		await fileHandle.close();
▲ Show 20 Lines • Show All 130 Lines • Show Last 20 Lines

[native] Add some memoization to `ImagePasteModal`ClosedPublicActions