Page MenuHomePhabricator
Differential D10101

[web] introduce light mode to manage invite link modal
ClosedPublic
Actions

Authored by ginsu on Nov 30 2023, 9:07 AM.
Tags
None
Referenced Files
F3696319: D10101.diff
Tue, Jan 7, 12:13 PM
Unknown Object (File)
Sun, Jan 5, 9:40 AM
Unknown Object (File)
Sat, Jan 4, 8:27 PM
Unknown Object (File)
Sun, Dec 22, 2:36 AM
Unknown Object (File)
Oct 31 2024, 8:21 AM
Unknown Object (File)
Oct 30 2024, 11:25 AM
Unknown Object (File)
Oct 2 2024, 12:42 AM
Unknown Object (File)
Oct 2 2024, 12:42 AM
View All 68 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
rohan
Commits
rCOMM6508a0a7bbd3: [web] introduce light mode to manage invite link modal
Summary

This diff introduces light mode to the manage invite link modal

For additional context about this new color design system and the new naming convention here is the notion doc:
https://www.notion.so/commapp/New-Color-System-Proposal-ef80b4e4b9ec42949095056161223a42

Linear task: https://linear.app/comm/issue/ENG-4836/manage-invite-links-modal

Test Plan

Please see the screenshots below

dark:

Screenshot 2023-11-30 at 12.09.56 PM.png (1×3 px, 763 KB)

Screenshot 2023-11-30 at 12.10.06 PM.png (1×3 px, 722 KB)

light:

Screenshot 2023-11-30 at 12.09.22 PM.png (1×3 px, 745 KB)

Screenshot 2023-11-30 at 12.09.13 PM.png (1×3 px, 723 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Nov 30 2023, 9:07 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 30 2023, 9:07 AM
ginsu edited the summary of this revision. (Show Details)Nov 30 2023, 9:10 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka, rohan.
ginsu attached a referenced file: F903487: Screenshot 2023-11-30 at 12.09.13 PM.png. (Show Details)
ginsu attached a referenced file: F903488: Screenshot 2023-11-30 at 12.09.22 PM.png. (Show Details)
ginsu attached a referenced file: F903490: Screenshot 2023-11-30 at 12.10.06 PM.png. (Show Details)
ginsu attached a referenced file: F903489: Screenshot 2023-11-30 at 12.09.56 PM.png. (Show Details)
ginsu added a child revision: D10103: [web] introduce light mode to view invite link modal.Nov 30 2023, 9:15 AM
Harbormaster completed remote builds in B24646: Diff 34058.Nov 30 2023, 9:27 AM
ginsu requested review of this revision.Nov 30 2023, 9:27 AM
rohan accepted this revision.Nov 30 2023, 1:37 PM
This revision is now accepted and ready to land.Nov 30 2023, 1:37 PM
ginsu updated this revision to Diff 34091.Nov 30 2023, 9:30 PM

rebase before landing

This revision was landed with ongoing or failed builds.Nov 30 2023, 9:32 PM
Closed by commit rCOMM6508a0a7bbd3: [web] introduce light mode to manage invite link modal (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM6508a0a7bbd3: [web] introduce light mode to manage invite link modal.
Harbormaster completed remote builds in B24677: Diff 34091.Nov 30 2023, 10:04 PM

Revision Contents
Changeset List

Diff 34058

View Options

web/invite-links/copy-invite-link-button.css

Loading...
View Options

web/invite-links/manage/empty-link-content.react.js

Loading...
View Options

web/invite-links/manage/existing-link-content.react.js

Loading...
View Options

web/invite-links/manage/manage-invite-links-modal.css

Loading...