Page MenuHomePhabricator
Differential D10156

[lib] Move mergeUserInfos
AbandonedPublic
Actions

Authored by inka on Dec 4 2023, 6:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 21, 10:00 PM
Unknown Object (File)
Sat, Sep 21, 7:16 PM
Unknown Object (File)
Sat, Sep 21, 7:12 PM
Unknown Object (File)
Sat, Sep 21, 6:27 PM
Unknown Object (File)
Sat, Sep 7, 8:57 PM
Unknown Object (File)
Sat, Sep 7, 9:55 AM
Unknown Object (File)
Sat, Sep 7, 9:26 AM
Unknown Object (File)
Fri, Sep 6, 10:30 PM
View All 32 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
michal
ginsu
atul
Summary

issue: https://linear.app/comm/issue/ENG-6001/logout-not-working-and-state-difference-after-invalid-session
this is a helper diff to the next one, to avoid circular dependencies

Test Plan

Ran yarn flow-all

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Dec 4 2023, 6:57 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 4 2023, 6:57 AM
inka added a child revision: D10157: [lib] Fix Logout not working and state difference after invalid session downgrade.Dec 4 2023, 7:06 AM
inka added a reviewer: atul.
Harbormaster completed remote builds in B24730: Diff 34188.Dec 4 2023, 8:02 AM
inka requested review of this revision.Dec 4 2023, 8:02 AM
inka edited the summary of this revision. (Show Details)Dec 4 2023, 8:08 AM
atul accepted this revision.Dec 4 2023, 9:37 AM

Guessing you meant something like flow instead of yarn for test plan?

This revision is now accepted and ready to land.Dec 4 2023, 9:37 AM
inka added a comment.Dec 5 2023, 2:32 AM
In D10156#295377, @atul wrote:

Guessing you meant something like flow instead of yarn for test plan?

Yes, sorry, I'll fix it

inka edited the test plan for this revision. (Show Details)Dec 5 2023, 2:32 AM
inka abandoned this revision.Dec 18 2023, 1:44 AM
inka removed a child revision: D10157: [lib] Fix Logout not working and state difference after invalid session downgrade.

This is not needed after all

Revision Contents
Changeset List

PathSize
lib/
actions/
2 lines
24 lines
utils/
19 lines

Diff 34188

View Options

lib/actions/siwe-actions.js

Loading...
View Options

lib/actions/user-actions.js

Loading...
View Options

lib/utils/action-utils.js

Loading...