Details

Reviewers

atul
ginsu
inka

Commits

rCOMMec35a73e89d0: [web] Update UserList to call useUserSearchIndex

Summary

There are several search experiences in the app that do not use get/usePotentialMemberItems. This means we need to update them individually, so I'm separating out diffs to do exactly this to make it easy for reviewers. [[ https://linear.app/comm/issue/ENG-6019/[after-landing]-try-to-update-remaining-search-experiences-to-use | ENG-6019 ]] tracks attempting to update these search experiences to use usePotentialMemberItems. Each diff will affect one file ideally.

This diff affects UserList.

This component is used when:

viewing friend list on web
viewing block list on web

Addresses ENG-5434

Depends on D10250

Test Plan

Please see the video below where I view the friend list and block list on web

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rohan created this revision.Dec 8 2023, 5:31 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 8 2023, 5:31 AM

rohan edited the test plan for this revision. (Show Details)Dec 8 2023, 5:32 AM

rohan added a child revision: D10252: [native] Update RelationshipList to call useUserSearchIndex.Dec 8 2023, 5:34 AM

Harbormaster completed remote builds in B24888: Diff 34418.Dec 8 2023, 5:59 AM

rohan requested review of this revision.Dec 8 2023, 5:59 AM

ashoat added inline comments.Dec 11 2023, 9:39 AM

web/settings/relationship/user-list.react.js
29 ↗	(On Diff #34418)	Same issue as here

Memoize values(userInfos)

Harbormaster completed remote builds in B24946: Diff 34482.Dec 11 2023, 10:46 AM

You can probably use the fact that your hook takes an arbitrary array of UserInfos, and apply filterUser on userInfosArray before passing it into useUserSearchIndex. This will reduce the amount of computation needed inside of your hook

inka mentioned this in D10252: [native] Update RelationshipList to call useUserSearchIndex.Dec 12 2023, 1:08 AM

Address feedback

Call filterUser before constructing the search index to reduce the size of it
Remove the use of filterUser later on in the file
Update filterUser types to be UserInfo instead of AccountUserInfo (UserInfo has all the necessary info and Flow won't complain since I'm passing in UserInfos from userStore)

rohan added inline comments.Dec 12 2023, 1:06 PM

web/settings/relationship/user-list.react.js
42 ↗	(On Diff #34545)	Changed this to `userInfosArray.map(u => u.id)` so instead of having all of the user IDs from the user store, it's now the user IDs from the filtered user infos
55 ↗	(On Diff #34545)	Already called `filterUser` on the original `userInfosArray` that's in the search index now, so I removed this instance of it