Paths

Table of Contentst

[native/lib] Cleanup existing JS backup code
ClosedPublic
Actions

Authored by michal on Dec 8 2023, 4:43 PM.

Details

Reviewers

kamil
bartek
varun

Commits

rCOMMdba1071473a2: [native/lib] Cleanup existing JS backup code

Summary

After D10264 we can remove some code that is no longer used. Also we improve the code in a few places:

better error messages
clear the BACKUP_HASH_STORAGE_KEY value when someone disables backup (so you can retrigger backup upload easily)

Depends on D10264

Test Plan

CI. Disable and enable backups and check if backup is uploaded again.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Dec 8 2023, 4:43 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 8 2023, 4:43 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 8 2023, 5:09 PM

Harbormaster failed remote builds in B24908: Diff 34442!

michal requested review of this revision.Dec 12 2023, 10:12 AM

Rebase

Harbormaster completed remote builds in B24988: Diff 34528.Dec 12 2023, 12:47 PM

bartek accepted this revision.Dec 14 2023, 8:11 AM

This revision is now accepted and ready to land.Dec 14 2023, 8:11 AM

Closed by commit rCOMMdba1071473a2: [native/lib] Cleanup existing JS backup code. · Explain WhyJan 3 2024, 3:04 PM

This revision was automatically updated to reflect the committed changes.

Restricted Repository Identity added a commit: rCOMMdba1071473a2: [native/lib] Cleanup existing JS backup code.

Revision Contents
Changeset List

Path

Size

lib/

facts/

backup-service.js

types/

backup-types.js

utils/

backup-service.js

native/

backup/

11 lines

8 lines

6 lines

profile/

backup-menu.react.js

2 lines

Diff 35157

View Options

lib/facts/backup-service.js

View Options

lib/types/backup-types.js

View Options

lib/utils/backup-service.js

View Options

native/backup/api.js

View Options

native/backup/backup-handler.js

View Options

native/backup/conversion-utils.js

View Options

native/backup/use-client-backup.js

View Options

native/profile/backup-menu.react.js

[native/lib] Cleanup existing JS backup codeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 35157

lib/facts/backup-service.js

lib/types/backup-types.js

lib/utils/backup-service.js

native/backup/api.js

native/backup/backup-handler.js

native/backup/conversion-utils.js

native/backup/use-client-backup.js

native/profile/backup-menu.react.js

[native/lib] Cleanup existing JS backup code
ClosedPublic
Actions

Revision Contents
Changeset List