Page MenuHomePhabricator
Differential D10265

[native/lib] Cleanup existing JS backup code
ClosedPublic
Actions

Authored by michal on Dec 8 2023, 8:43 AM.
Tags
None
Referenced Files
F2190853: D10265.id.diff
Thu, Jul 4, 12:50 PM
Unknown Object (File)
Wed, Jul 3, 12:45 AM
Unknown Object (File)
Thu, Jun 27, 7:52 PM
Unknown Object (File)
Tue, Jun 25, 11:49 AM
Unknown Object (File)
Tue, Jun 25, 11:49 AM
Unknown Object (File)
Tue, Jun 25, 11:49 AM
Unknown Object (File)
Tue, Jun 25, 11:49 AM
Unknown Object (File)
Tue, Jun 25, 11:49 AM
View All 33 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
bartek
varun
Commits
rCOMMdba1071473a2: [native/lib] Cleanup existing JS backup code
Summary

After D10264 we can remove some code that is no longer used. Also we improve the code in a few places:

  • better error messages
  • clear the BACKUP_HASH_STORAGE_KEY value when someone disables backup (so you can retrigger backup upload easily)

Depends on D10264

Test Plan

CI. Disable and enable backups and check if backup is uploaded again.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

Diff 34528

View Options

lib/facts/backup-service.js

Loading...
View Options

lib/types/backup-types.js

Loading...
View Options

lib/utils/backup-service.js

Loading...
View Options

native/backup/api.js

Loading...
View Options

native/backup/backup-handler.js

Loading...
View Options

native/backup/conversion-utils.js

Loading...
View Options

native/backup/use-client-backup.js

Loading...
View Options

native/profile/backup-menu.react.js

Loading...