Page MenuHomePhabricator
Differential D10337

Enable sending auth metadata event from Rust
ClosedPublic
Actions

Authored by marcin on Dec 14 2023, 5:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 27, 10:03 PM
Unknown Object (File)
Wed, Nov 27, 4:32 AM
Unknown Object (File)
Tue, Nov 26, 11:48 PM
Unknown Object (File)
Mon, Nov 18, 6:39 PM
Unknown Object (File)
Sun, Nov 10, 10:23 AM
Unknown Object (File)
Wed, Nov 6, 4:51 AM
Unknown Object (File)
Oct 18 2024, 1:51 AM
Unknown Object (File)
Oct 18 2024, 1:51 AM
View All 80 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
michal
bartek
kamil
Commits
rCOMM6a2c0466a431: Enable sending auth metadata event from Rust
Summary

This differential enables Rust code to send auth metadata event to JS.

Test Plan
  1. Apply this diff from @kamil: https://phab.comm.dev/D10327
  2. Put a call to send_auth_metadata_to_js in one of Rust functions used in the diff linked above. Unfortunately you have to pass dummy hardcoded strings instead of real data from identity service sue to the issue: https://linear.app/comm/issue/ENG-6067/grpc-on-native-physical-device-not-working
  3. Subscribe in JS to auth metadata event (as in previous diffs)
  4. Launch the app. Ensure that dummy metadata is logged.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.Dec 14 2023, 5:02 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 14 2023, 5:02 AM
marcin added a parent revision: D10336: Enable JS to subscribe to auth metadata events.Dec 14 2023, 5:02 AM
marcin edited the test plan for this revision. (Show Details)Dec 14 2023, 5:20 AM
marcin updated this revision to Diff 34636.Dec 14 2023, 5:26 AM

Rebase

Harbormaster completed remote builds in B25066: Diff 34631.Dec 14 2023, 5:47 AM
Harbormaster completed remote builds in B25071: Diff 34636.Dec 14 2023, 7:05 AM
marcin requested review of this revision.Dec 14 2023, 7:05 AM
varun accepted this revision.Dec 14 2023, 10:28 PM

lgtm!

This revision is now accepted and ready to land.Dec 14 2023, 10:28 PM
bartek accepted this revision.Dec 15 2023, 3:00 AM
marcin updated this revision to Diff 34711.Dec 15 2023, 5:49 AM
  1. Refactor to remove deviceID emission.
  2. Rebase before landing.
Harbormaster completed remote builds in B25121: Diff 34711.Dec 15 2023, 6:45 AM
Closed by commit rCOMM6a2c0466a431: Enable sending auth metadata event from Rust (authored by marcin). · Explain WhyDec 15 2023, 6:48 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM6a2c0466a431: Enable sending auth metadata event from Rust.

Revision Contents
Changeset List

PathSize
native/
android/
app/
1 line
ios/
Comm.xcodeproj/
6 lines
native_rust_library/
9 lines
8 lines
src/
17 lines

Diff 34718

View Options

native/android/app/CMakeLists.txt

Loading...
View Options

native/ios/Comm.xcodeproj/project.pbxproj

Loading...
View Options

native/native_rust_library/RustCSAMetadataEmitter.h

Loading...
View Options

native/native_rust_library/RustCSAMetadataEmitter.cpp

Loading...
View Options

native/native_rust_library/src/lib.rs

Loading...