Paths

Table of Contentst

-
lib/shared/
-
shared/
-
mention-utils.js

Differential D10462

[lib] Fix typo in useMentionTypeaheadUserSuggestions
ClosedPublic
Actions

Authored by rohan on Dec 26 2023, 11:59 AM.

Tags

None

Referenced Files

	F5237193: D10462.id.diff
	Sat, Apr 5, 2:14 PM

	F5221220: D10462.id35010.diff
	Sat, Apr 5, 1:29 AM

	F5214968: D10462.id35020.diff
	Fri, Apr 4, 11:37 PM

	Unknown Object (File)
	Fri, Apr 4, 2:33 PM

	Unknown Object (File)
	Thu, Apr 3, 10:56 PM

	Unknown Object (File)
	Tue, Mar 11, 7:57 PM

	Unknown Object (File)
	Mar 4 2025, 4:27 PM

	Unknown Object (File)
	Mar 3 2025, 4:16 PM

View All 80 Files

Subscribers

Details

Reviewers

atul
ginsu
inka

Commits

rCOMMa37fd35408a6: [lib] Fix typo in useMentionTypeaheadUserSuggestions

Summary

Small typo I noticed that I introduced

Test Plan

flow just to make sure I didn't miss an instance

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rohan created this revision.Dec 26 2023, 11:59 AM

Herald added a subscriber: tomek. · View Herald TranscriptDec 26 2023, 11:59 AM

rohan removed a reviewer: ashoat.Dec 26 2023, 11:59 AM

rohan edited the summary of this revision. (Show Details)Dec 26 2023, 12:04 PM

rohan edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B25341: Diff 35010.Dec 26 2023, 12:17 PM

rohan requested review of this revision.Dec 26 2023, 12:17 PM

atul accepted this revision.Dec 26 2023, 5:27 PM

This revision is now accepted and ready to land.Dec 26 2023, 5:27 PM

Closed by commit rCOMMa37fd35408a6: [lib] Fix typo in useMentionTypeaheadUserSuggestions (authored by rohan). · Explain WhyDec 27 2023, 7:50 AM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMMa37fd35408a6: [lib] Fix typo in useMentionTypeaheadUserSuggestions.

Revision Contents
Changeset List

Path

Size

lib/

shared/

mention-utils.js

6 lines

Diff 35020

lib/shared/mention-utils.js

	Show All 33 Lines
	function useCreateDesktopPushSubscription() {			function useCreateDesktopPushSubscription() {
	const dispatchActionPromise = useDispatchActionPromise();			const dispatchActionPromise = useDispatchActionPromise();
	const callSetDeviceToken = useSetDeviceTokenFanout();			const callSetDeviceToken = useSetDeviceTokenFanout();
	const staffCanSee = useStaffCanSee();			const staffCanSee = useStaffCanSee();

	React.useEffect(			React.useEffect(
	() =>			() =>
	electron?.onDeviceTokenRegistered?.((token: ?string) => {			electron?.onDeviceTokenRegistered?.((token: ?string) => {
	dispatchActionPromise(			void dispatchActionPromise(
	setDeviceTokenActionTypes,			setDeviceTokenActionTypes,
	callSetDeviceToken(token),			callSetDeviceToken(token),
	);			);
	}),			}),
	[callSetDeviceToken, dispatchActionPromise],			[callSetDeviceToken, dispatchActionPromise],
	);			);

	React.useEffect(() => {			React.useEffect(() => {
	▲ Show 20 Lines • Show All 181 Lines • Show Last 20 Lines