[web] introduce AppList
ClosedPublic
Actions

Authored by ginsu on Dec 27 2023, 9:01 PM.

Details

Reviewers

atul
kamil
rohan

Commits

rCOMM76943624a5ef: [web] introduce AppList

Summary

This diff introduces the AppList component. The AppList component brings together all the other app list sub components to create the App List card

For context here is what the figma designs look like:

Screenshot 2023-12-27 at 11.52.43 PM.png (1×506 px, 152 KB)

Linear task: https://linear.app/comm/issue/ENG-5962/create-new-app-list-card-section

Depends on D10470

Test Plan

Please see the demo video below (please excuse the testing tooltip + blue calendar those are local changes that were not included in this diff)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Dec 27 2023, 9:01 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 27 2023, 9:01 PM

ginsu edited the summary of this revision. (Show Details)Dec 27 2023, 9:04 PM

ginsu added reviewers: atul, kamil, rohan.

ginsu attached a referenced file: F1010576: Screenshot 2023-12-27 at 11.52.43 PM.png. (Show Details)

ginsu edited the test plan for this revision. (Show Details)

ginsu attached a referenced file: F1010616: Screen Recording 2023-12-28 at 12.04.46 AM.mov. (Show Details)

ginsu edited the test plan for this revision. (Show Details)Dec 27 2023, 9:07 PM

ginsu added inline comments.Dec 27 2023, 9:13 PM

web/app-list/app-list.react.js
14 ↗	(On Diff #35038)	Most of this logic is taken from `AppSwitcher`. I intentionally decided to not delete the code in `AppSwitcher` because I want to make sure that I can land this diff as is w/o worrying about creating regressions/breaking changes. To make it easy to review tho, I will point out where the duplicated logic is. https://linear.app/comm/issue/ENG-5963/remove-old-horizontal-app-list tracks removing the `AppSwitcher`
16–24 ↗	(On Diff #35038)	https://github.com/CommE2E/comm/blob/master/web/navigation-panels/app-switcher.react.js#L72-L83
41–49 ↗	(On Diff #35038)	https://github.com/CommE2E/comm/blob/master/web/navigation-panels/app-switcher.react.js#L17-L25
51–66 ↗	(On Diff #35038)	https://github.com/CommE2E/comm/blob/master/web/navigation-panels/app-switcher.react.js#L29-L48